Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add namespace patching #378

Merged
merged 2 commits into from
Apr 29, 2024
Merged

e2e: add namespace patching #378

merged 2 commits into from
Apr 29, 2024

Conversation

wirungu
Copy link
Contributor

@wirungu wirungu commented Apr 25, 2024

No description provided.

@wirungu wirungu added the no changelog PRs not listed in the release notes label Apr 25, 2024
@wirungu wirungu requested a review from burgerdev April 25, 2024 04:39
@wirungu wirungu requested a review from katexochen as a code owner April 25, 2024 04:39
@wirungu wirungu marked this pull request as draft April 25, 2024 04:39
e2e/internal/contrasttest/contrasttest.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/resourcegen/main.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/resourcegen/main.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
@katexochen katexochen removed their request for review April 26, 2024 07:55
@wirungu wirungu force-pushed the mi/e2e-namespace branch 2 times, most recently from 8ad664e to eb830a4 Compare April 26, 2024 10:13
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@wirungu wirungu marked this pull request as ready for review April 26, 2024 14:12
@burgerdev burgerdev merged commit 9678866 into main Apr 29, 2024
7 checks passed
@burgerdev burgerdev deleted the mi/e2e-namespace branch April 29, 2024 11:27
@burgerdev
Copy link
Contributor

I squashed the commits because they are dependent: can't remove the namespace check while the namespace objects are not removed from the sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants