Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: respect env vars #58

Merged
merged 3 commits into from
Jan 9, 2024
Merged

logging: respect env vars #58

merged 3 commits into from
Jan 9, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Jan 8, 2024 •
edited
Loading

No description provided.

@malt3 malt3 force-pushed the feat/logging/env-vars branch 3 times, most recently from e9b3951 to 1959867 Compare January 9, 2024 09:56
@malt3 malt3 marked this pull request as ready for review January 9, 2024 09:58
@malt3 malt3 requested a review from katexochen as a code owner January 9, 2024 09:58
@malt3 malt3 force-pushed the feat/logging/env-vars branch from 1959867 to a6112b4 Compare January 9, 2024 10:25
@malt3 malt3 marked this pull request as draft January 9, 2024 10:26
katexochen
katexochen requested changes Jan 9, 2024
View reviewed changes
coordinator/main.go Outdated Show resolved Hide resolved
cli/set.go Outdated Show resolved Hide resolved
cli/verify.go Outdated Show resolved Hide resolved
internal/logger/handler.go Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/logging/env-vars branch 2 times, most recently from 57abb97 to 3c7b5df Compare January 9, 2024 11:27
@malt3 malt3 marked this pull request as ready for review January 9, 2024 11:29
@malt3 malt3 requested a review from katexochen January 9, 2024 11:29
katexochen
katexochen requested changes Jan 9, 2024
View reviewed changes
coordinator/main.go Outdated Show resolved Hide resolved
initializer/main.go Outdated Show resolved Hide resolved
internal/attestation/snp/validator.go Outdated Show resolved Hide resolved
internal/logger/handler.go Outdated Show resolved Hide resolved
tools/parsesnp.go Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/logging/env-vars branch 2 times, most recently from 853f084 to 9080513 Compare January 9, 2024 13:24
katexochen
katexochen requested changes Jan 9, 2024
View reviewed changes
internal/logger/logger.go Outdated Show resolved Hide resolved
internal/logger/handler_test.go Outdated Show resolved Hide resolved
internal/logger/handler.go Outdated Show resolved Hide resolved
internal/logger/handler.go Outdated Show resolved Hide resolved
katexochen
katexochen requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least configure out deployments to use debug logging on the default logger.

coordinator/intercom.go Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/logging/env-vars branch from 9080513 to 05d1d78 Compare January 9, 2024 14:24
@katexochen katexochen mentioned this pull request Jan 9, 2024
Merged
@malt3 malt3 force-pushed the feat/logging/env-vars branch from 05d1d78 to 4e8e729 Compare January 9, 2024 14:36
@malt3 malt3 requested a review from 3u13r as a code owner January 9, 2024 14:36
@malt3 malt3 force-pushed the feat/logging/env-vars branch 3 times, most recently from 64dc7b9 to 7e1ed3f Compare January 9, 2024 14:49
3u13r
3u13r approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployments look good

@malt3 malt3 force-pushed the feat/logging/env-vars branch from 7e1ed3f to 5667c0d Compare January 9, 2024 14:51
@malt3 malt3 requested a review from katexochen January 9, 2024 14:58
@malt3 malt3 force-pushed the feat/logging/env-vars branch from 5667c0d to 2601b63 Compare January 9, 2024 15:41
@malt3
Copy link
Contributor Author

malt3 commented Jan 9, 2024

Should be ready now.

@malt3 malt3 merged commit fdb7ce9 into main Jan 9, 2024
4 checks passed
@malt3 malt3 deleted the feat/logging/env-vars branch January 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@3u13r 3u13r 3u13r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malt3 @3u13r @katexochen