Skip to content

Commit

Permalink
Merge pull request #90 from mole99/fixes
Browse files Browse the repository at this point in the history
Improvements to the summary, allow null in yaml
  • Loading branch information
mole99 authored Jul 10, 2024
2 parents 4825073 + 7774c31 commit 31f4ece
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 11 deletions.
9 changes: 8 additions & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
# 2.3.9
# 2.3.11

## Common

- Bugfix: Do not crash if certain entries are missing from authorship
- Improvement: Allow to specify `'null'` as `null`

# 2.3.10

## Common

Expand Down
2 changes: 1 addition & 1 deletion cace/__version__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
__version__ = '2.3.10'
__version__ = '2.3.11'

if __name__ == '__main__':
print(__version__, end='')
18 changes: 9 additions & 9 deletions cace/common/cace_write.py
Original file line number Diff line number Diff line change
Expand Up @@ -900,21 +900,21 @@ def markdown_summary(datasheet):
result += ''.join(
[
f'**general**\n\n',
f'- name: {datasheet["name"]}\n',
f'- description: {datasheet["description"]}\n',
f'- commit: {datasheet["commit"]}\n',
f'- PDK: {datasheet["PDK"]}\n',
f'- cace_format: {datasheet["cace_format"]}\n\n',
f'- name: {datasheet["name"] if "name" in datasheet else ""}\n',
f'- description: {datasheet["description"] if "description" in datasheet else ""}\n',
f'- commit: {datasheet["commit"] if "commit" in datasheet else ""}\n',
f'- PDK: {datasheet["PDK"] if "PDK" in datasheet else ""}\n',
f'- cace_format: {datasheet["cace_format"] if "cace_format" in datasheet else ""}\n\n',
]
)

result += ''.join(
[
f'**authorship**\n\n',
f'- designer: {datasheet["authorship"]["designer"]}\n',
f'- company: {datasheet["authorship"]["company"]}\n',
f'- creation_date: {datasheet["authorship"]["creation_date"]}\n',
f'- license: {datasheet["authorship"]["license"]}\n\n',
f'- designer: {datasheet["authorship"]["designer"] if "designer" in datasheet["authorship"] else ""}\n',
f'- company: {datasheet["authorship"]["company"] if "company" in datasheet["authorship"] else ""}\n',
f'- creation_date: {datasheet["authorship"]["creation_date"] if "creation_date" in datasheet["authorship"] else ""}\n',
f'- license: {datasheet["authorship"]["license"] if "license" in datasheet["authorship"] else ""}\n\n',
]
)

Expand Down
4 changes: 4 additions & 0 deletions cace/parameter/simulation_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,10 @@ def simulate(self, testbench, idy):

# Format variables *must* exist in the parameter's "variables".
for varname in formatvars:
# Support real null in yaml
if varname == None:
varname = 'null'

if varname != 'null' and varname != 'result':
if 'variables' not in self.param or varname not in varnamelist:
err(
Expand Down

0 comments on commit 31f4ece

Please sign in to comment.