Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update yosys #464

Closed
wants to merge 1 commit into from
Closed

update yosys #464

wants to merge 1 commit into from

Conversation

rowanG077
Copy link

@rowanG077 rowanG077 commented May 5, 2024

Blocked on: chipsalliance/synlig#2431

I wanted to try out tinytapeout but quickly got stuck that my generated code was giving spurious logic loop warnings. This was an issue in yosys but was fixed in YosysHQ/yosys#4184

But since tinytapeout requires stuff to work in CI I have no choice but to update yosys across the stack.

If it is acceptable I can pull the PR to synlig as a patch so this could get merged faster.

@donn
Copy link
Member

donn commented May 7, 2024

Hi Rowan, thanks for the contribution. I have two comments:

  • The PR to Synlig will indeed need to be a patch, kind of like Yosys' patches.
  • As of 2.0.0's release, we only merge hotfixes to main, with any less urgent changes merged to dev for the next minor release. An issue with a reproducible showing the failure goes a long way to helping me get this in main. (You can create a reproducible out of any step by going to the failing/misbehaving step's directory and writing openlane.steps create-reproducible ., then tarballing the reproducible directory.)

@donn donn added the 💬 waiting on op This issue requires more information from its original creator label Jun 2, 2024
@donn
Copy link
Member

donn commented Sep 22, 2024

superseded by #534 - thank you for your effort

@donn donn closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 waiting on op This issue requires more information from its original creator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants