Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: dynamic designformat registration #612

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

donn
Copy link
Member

@donn donn commented Dec 3, 2024

Misc Enhancements/Bugfixes

  • openlane.state
    • DesignFormat
      • Now a dataclass encapsulating the information about the DesignFormat directly.
      • .factory is a factory for retrieval of DesignFormats by ID
        • DesignFormats may be registered to the factory using .register()
        • Registrations for previously included DesignFormats now moved to where appropriate.
          • Renamed POWERED_NETLIST_NO_PHYSICAL_CELLS to LOGICAL_POWERED_NETLIST
    • State
      • States no longer use ALL DesignFormats as keys. However, attempting to subscript with a DesignFormat that does not exist now returns None to help avoid extensive codebase changes.
      • States initialized with keys that have values that are None now remove said keys.

API Breaks

  • openlane.state
    • DesignFormat is no longer an enumeration and is not iterable. However, to avoid massive codebase changes, you can still access DesignFormats registered to the factory using the dot notation (e.g. DesignFormat.NETLIST), using either their id, name, or any of its alts.
    • Removed DesignFormatObject: the DesignFormat class itself is now a dataclass incorporating these fields, except name, which has been renamed to full_name

@donn donn marked this pull request as ready for review December 3, 2024 12:16
@donn donn requested a review from kareefardi December 3, 2024 12:16
@openlane-bot
Copy link
Collaborator

openlane-bot commented Dec 3, 2024

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/95ae9040af7a6defbed66310e74b3ef3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants