Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finer timing in ManifoldCAD.org #1099

Merged
merged 1 commit into from
Dec 4, 2024
Merged

finer timing in ManifoldCAD.org #1099

merged 1 commit into from
Dec 4, 2024

Conversation

elalish
Copy link
Owner

@elalish elalish commented Dec 4, 2024

I've been playing around with timing our mesh smoothing SDF vs increasing SDF resolution, but the timings were giving me odd results: see this ManifoldCAD example. Turns out most of the time was being spent in file export, not the actual Manifold library. So here I've split the timing into two parts: Manifold time and export time.

However, during the process I found that GLB export is next to instant - the real time killer is 3MF export, particularly the zip. I'm thinking now it would be better to do the 3MF export on save rather than on run. I wonder if we can just pass the whole to3mf JSON object out of the worker? Makes the API a bit less clean, but...

@elalish elalish self-assigned this Dec 4, 2024
@elalish elalish requested a review from pca006132 December 4, 2024 06:54
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (a13ceab) to head (346a0a5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1099   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          30       30           
  Lines        5883     5883           
=======================================
  Hits         5405     5405           
  Misses        478      478           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132
Copy link
Collaborator

Sorry, but I really want to make a meme for this:

image

@elalish
Copy link
Owner Author

elalish commented Dec 4, 2024

I guess I'll go ahead an merge this for now, though I think now the better course will be to revert this, have the worker only generate a GLB, then have the Save3MF button convert the GLB to a 3MF. This'll simplify our worker API too, which will make it nicer to put out as its own npm package. But that'll take longer, so it'll have to wait.

@elalish elalish merged commit 517a224 into master Dec 4, 2024
25 checks passed
@elalish elalish deleted the ManifoldCADtiming branch December 4, 2024 19:11
@elalish elalish mentioned this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants