Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with timing our mesh smoothing SDF vs increasing SDF resolution, but the timings were giving me odd results: see this ManifoldCAD example. Turns out most of the time was being spent in file export, not the actual Manifold library. So here I've split the timing into two parts: Manifold time and export time.
However, during the process I found that GLB export is next to instant - the real time killer is 3MF export, particularly the zip. I'm thinking now it would be better to do the 3MF export on save rather than on run. I wonder if we can just pass the whole
to3mf
JSON object out of the worker? Makes the API a bit less clean, but...