csg-tree: fix subtraction #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 30 30
Lines 5883 5885 +2
=======================================
+ Hits 5405 5407 +2
Misses 478 478 ☔ View full report in Codecov by Sentry. |
elalish
approved these changes
Dec 7, 2024
src/csg_tree.cpp
Outdated
| @@ -494,7 +498,7 @@ std::shared_ptr<CsgLeafNode> CsgOpNode::ToLeafNode() const { | |||
| // Before performing boolean operations, we should make sure that all children | |||
| // are `CsgLeafNodes`, i.e. are actual meshes that can be operated on. Hence, | |||
| // we do it in two steps: | |||
| // 1. Populate `children` (`left_children` and `right_children`, see below) | |||
| // 1. Populate `children` (`positive_children` and `positive_children`) | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1102.