Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align CI go version #101

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Align CI go version #101

merged 3 commits into from
Jul 22, 2024

Conversation

jlind23
Copy link
Contributor

@jlind23 jlind23 commented Jul 22, 2024

trying to align the go version used in CI with the one we used for this project - https://github.com/elastic/elastic-agent-autodiscover/blob/main/.go-version

@jlind23
Align CI go version
3e62b69 
trying to align the go version used in CI with the one we used for this project - https://github.com/elastic/elastic-agent-autodiscover/blob/main/.go-version
@jlind23 jlind23 requested a review from a team as a code owner July 22, 2024 17:51
@jlind23 jlind23 requested review from AndersonQ and leehinman July 22, 2024 17:51
@jlind23 jlind23 self-assigned this Jul 22, 2024
@jlind23 jlind23 mentioned this pull request Jul 22, 2024
Merged
@cmacknz cmacknz requested a review from pazone July 22, 2024 17:52
cmacknz
cmacknz reviewed Jul 22, 2024
View reviewed changes
.buildkite/pipeline.yml Outdated
@@ -2,7 +2,7 @@

env:
SETUP_GVM_VERSION: 'v0.5.0'
GO_VERSION_CHOCO: "1.20.5"
GO_VERSION_CHOCO: "1.21.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get the value from the content of https://github.com/elastic/elastic-agent-autodiscover/blob/main/.go-version.

If this YAML block doesn't support it, this can be done in the individual scripts. Elastic Agent installs GVM which knows how to read the .go-version file to deal with this. https://github.com/elastic/elastic-agent/blob/4d074b9ff02433e0c3a70f5e31d55db52fbd9b9d/.ci/scripts/install-go.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it seems like chocolatey does not offer all the available go version for windows - https://community.chocolatey.org/packages/golang#versionhistory 1.21.7 seems to be the last one in the 1.21.x serie

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this repository to Go 1.22 then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.22.5 and running

@jlind23 jlind23 enabled auto-merge (squash) July 22, 2024 18:33
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @jlind23

@jlind23 jlind23 merged commit 9e97f9d into main Jul 22, 2024
3 checks passed
@cmacknz cmacknz deleted the jlind23-patch-1 branch July 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

@pazone pazone Awaiting requested review from pazone

Assignees

@jlind23 jlind23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlind23 @elasticmachine @cmacknz