Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align CI go version #101

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Align CI go version #101

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e62b69
Align CI go version
jlind23 Jul 22, 2024
fec6f59
Update pipeline.yml
jlind23 Jul 22, 2024
7a2e3da
Update pipeline.yml
jlind23 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

env:
SETUP_GVM_VERSION: 'v0.5.0'
GO_VERSION_CHOCO: "1.20.5"
GO_VERSION_CHOCO: "1.21.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get the value from the content of https://github.com/elastic/elastic-agent-autodiscover/blob/main/.go-version.

If this YAML block doesn't support it, this can be done in the individual scripts. Elastic Agent installs GVM which knows how to read the .go-version file to deal with this. https://github.com/elastic/elastic-agent/blob/4d074b9ff02433e0c3a70f5e31d55db52fbd9b9d/.ci/scripts/install-go.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it seems like chocolatey does not offer all the available go version for windows - https://community.chocolatey.org/packages/golang#versionhistory 1.21.7 seems to be the last one in the 1.21.x serie

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this repository to Go 1.22 then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.22.5 and running

LINUX_AGENT_IMAGE: "golang:${GO_VERSION}"
WINDOWS_AGENT_IMAGE: "family/core-windows-2022"

Expand Down
Loading