[CI] Add support for running tests with stack 9.0.0 #11138
Conversation
🚀 Benchmarks reportTo see the full report comment with |
💔 Build Failed
Failed CI StepsHistory
cc @mrodm |
mrodm
force-pushed
the
update-ci-9.0
branch
from
7b2fe31
to
e6c4f01
Compare
| depends_on: | ||
| - step: "check" | ||
| allow_failure: false |
There was a problem hiding this comment.
Would it be interesting to run this step after finishing the tests with 8.x ?
It would be updating the step defined in the depends_on field.
To avoid creating another build to test 290 packages at the same time (not sure if that could be an issue). WDYT?
There was a problem hiding this comment.
Well, this is going to be temporary, I guess that some time after 9.0 is released, 7.x will become unmaintained and we will remove its stage.
If it depends on 8.x, will it be executed if 8.x fails? We want both to be executed even if the other fails, what is pretty common 😅
There was a problem hiding this comment.
Yes, it should be able to do that by setting depends_on as:
depends_on:
- step: "local-8-stack"
allow_failure: true
Once it is removed 7.x, it can be reverted the depends_on configuration too.
There was a problem hiding this comment.
I'll add this for now at least for daily
There was a problem hiding this comment.
But is it a problem to run so many stages at the same time? It looks like we are fixing an issue we don't have (yet?).
I don't have a strong preference with any of the options, but it looks simpler to just run everything at the same time if this is not a problem by now.
There was a problem hiding this comment.
That's true, I'm just moving ahead and probably there would not be any issue.
I'll change it back, and if there are issues we can do this change then.
| depends_on: | ||
| - step: "check" | ||
| allow_failure: false |
There was a problem hiding this comment.
Same as in the daily job? Would it be interesting to trigger this after the other step testing 8.x has finished? (update depends_on field).
| matchpattern: '(STACK_VERSION:) 9\.[^\s]*\.[^\s]*' | ||
| replacepattern: '$1 {{ source "latestSnapshot" }}' | ||
|
|
||
| update-snapshot-label-weekly: |
There was a problem hiding this comment.
These steps are now failing in the current check, but they should work once this PR is merged and all the changes are in main branch.
There was a problem hiding this comment.
Thanks for adding the updatecli config too 👍
| depends_on: | ||
| - step: "check" | ||
| allow_failure: false |
There was a problem hiding this comment.
Well, this is going to be temporary, I guess that some time after 9.0 is released, 7.x will become unmaintained and we will remove its stage.
If it depends on 8.x, will it be executed if 8.x fails? We want both to be executed even if the other fails, what is pretty common 😅
.buildkite/pipeline.yml
Outdated
| if: > | ||
| build.source == "trigger_job" && build.env('BUILDKITE_TRIGGERED_FROM_BUILD_PIPELINE_SLUG') == "integrations-schedule-daily" | ||
| build.source == "trigger_job" && build.env('BUILDKITE_TRIGGERED_FROM_BUILD_PIPELINE_SLUG') == "integrations-schedule-daily" && build.env('STACK_VERSION') !~ /^9/ |
| matchpattern: '(STACK_VERSION:) 9\.[^\s]*\.[^\s]*' | ||
| replacepattern: '$1 {{ source "latestSnapshot" }}' | ||
|
|
||
| update-snapshot-label-weekly: |
There was a problem hiding this comment.
Thanks for adding the updatecli config too 👍
mrodm
force-pushed
the
update-ci-9.0
branch
from
f688f46
to
441f7e8
Compare
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @mrodm |
|
Proposed commit message
Add support for running tests with stack 9.0.0.
Add new steps in daily and weekly pipelines for testing packages with stack 9.0.0 (without reporting issues for now).
Author's Checklist
Related issues
kibana.versionof9.0.0is provided package-registry#1226