-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add support for running tests with stack 9.0.0 #11138
Changes from 13 commits
2348f2b
90042ff
40f864d
ea11883
4d3ba1e
be020b3
5538d14
0dcfdcc
c4f13fd
a0cbd5b
72f4e8d
3455508
e6c4f01
5163e39
c36dd31
9954b20
441f7e8
846b407
19ea0ef
db0bfed
c8ed84b
bbeef79
26db499
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,3 +27,16 @@ steps: | |
depends_on: | ||
- step: "check" | ||
allow_failure: false | ||
|
||
- label: "Check integrations local stacks and non-wolfi images for Elastic Agent - Stack Version v9.0" | ||
trigger: "integrations" | ||
build: | ||
env: | ||
SERVERLESS: "false" | ||
FORCE_CHECK_ALL: "true" | ||
STACK_VERSION: 9.0.0-SNAPSHOT | ||
PUBLISH_COVERAGE_REPORTS: "false" | ||
ELASTIC_PACKAGE_DISABLE_ELASTIC_AGENT_WOLFI: "true" | ||
depends_on: | ||
- step: "check" | ||
allow_failure: false | ||
Comment on lines
+40
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as in the daily job? Would it be interesting to trigger this after the other step testing 8.x has finished? (update |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,5 +102,6 @@ steps: | |
# not fail build if this step fails | ||
soft_fail: true | ||
# run this step when if it is triggered by the daily job | ||
# skipped for now notification for tests related to STACK_VERSION: 9 | ||
if: > | ||
build.source == "trigger_job" && build.env('BUILDKITE_TRIGGERED_FROM_BUILD_PIPELINE_SLUG') == "integrations-schedule-daily" | ||
build.source == "trigger_job" && build.env('BUILDKITE_TRIGGERED_FROM_BUILD_PIPELINE_SLUG') == "integrations-schedule-daily" && build.env('STACK_VERSION') !~ /^9/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
--- | ||
name: Bump latest 9.x-SNAPSHOT elastic-stack test version | ||
pipelineid: 'bump-latest-9x-elastic-stack-version' | ||
|
||
actions: | ||
default: | ||
title: '[updatecli] Update latest snapshot to {{ source "latestSnapshot" }}' | ||
kind: github/pullrequest | ||
scmid: default | ||
spec: | ||
labels: | ||
- automation | ||
- dependency | ||
|
||
scms: | ||
default: | ||
kind: github | ||
spec: | ||
owner: '{{ .scm.owner }}' | ||
repository: '{{ .scm.repository }}' | ||
user: '{{ requiredEnv "GITHUB_ACTOR" }}' | ||
username: '{{ requiredEnv "GITHUB_ACTOR" }}' | ||
token: '{{ requiredEnv "GITHUB_TOKEN" }}' | ||
commitusingapi: true | ||
branch: main | ||
|
||
sources: | ||
latestSnapshot: | ||
name: Get latest snapshot | ||
kind: json | ||
spec: | ||
file: https://storage.googleapis.com/artifacts-api/snapshots/main.json | ||
key: .version | ||
latestSnapshotMajorMinor: | ||
name: Get latest snapshort major and minor | ||
kind: json | ||
spec: | ||
file: https://storage.googleapis.com/artifacts-api/snapshots/main.json | ||
key: .version | ||
transformers: | ||
- findsubmatch: | ||
pattern: '(^\d+\.\d+)\.[^\s]+$' | ||
captureindex: 1 | ||
|
||
targets: | ||
update-snapshot-daily: | ||
name: '[updatecli] [daily] Update latest snapshot to {{ source "latestSnapshot" }}' | ||
kind: file | ||
sourceid: latestSnapshot | ||
scmid: default | ||
spec: | ||
file: '.buildkite/pipeline.schedule-daily.yml' | ||
matchpattern: '(STACK_VERSION:) 9\.[^\s]*\.[^\s]*' | ||
replacepattern: '$1 {{ source "latestSnapshot" }}' | ||
|
||
update-snapshot-label-daily: | ||
name: '[updatecli] [daily] Update latest snapshot label step to {{ source "latestSnapshotMajorMinor" }}' | ||
kind: file | ||
sourceid: latestSnapshotMajorMinor | ||
scmid: default | ||
spec: | ||
file: '.buildkite/pipeline.schedule-daily.yml' | ||
matchpattern: '(Stack Version) v9\.\d+"' | ||
replacepattern: 'Stack Version v{{ source "latestSnapshotMajorMinor" }}"' | ||
|
||
update-snapshot-weekly: | ||
name: '[updatecli] [weekly] Update latest snapshot to {{ source "latestSnapshot" }}' | ||
kind: file | ||
sourceid: latestSnapshot | ||
scmid: default | ||
spec: | ||
file: '.buildkite/pipeline.schedule-weekly.yml' | ||
matchpattern: '(STACK_VERSION:) 9\.[^\s]*\.[^\s]*' | ||
replacepattern: '$1 {{ source "latestSnapshot" }}' | ||
|
||
update-snapshot-label-weekly: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These steps are now failing in the current check, but they should work once this PR is merged and all the changes are in main branch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for adding the updatecli config too 👍 |
||
name: '[updatecli] [weekly] Update latest snapshot label step to {{ source "latestSnapshotMajorMinor" }}' | ||
kind: file | ||
sourceid: latestSnapshotMajorMinor | ||
scmid: default | ||
spec: | ||
file: '.buildkite/pipeline.schedule-weekly.yml' | ||
matchpattern: '(Stack Version) v9\.\d+"' | ||
replacepattern: 'Stack Version v{{ source "latestSnapshotMajorMinor" }}"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be interesting to run this step after finishing the tests with 8.x ?
It would be updating the step defined in the
depends_on
field.To avoid creating another build to test 290 packages at the same time (not sure if that could be an issue). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is going to be temporary, I guess that some time after 9.0 is released, 7.x will become unmaintained and we will remove its stage.
If it depends on 8.x, will it be executed if 8.x fails? We want both to be executed even if the other fails, what is pretty common 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be able to do that by setting
depends_on
as:Once it is removed 7.x, it can be reverted the
depends_on
configuration too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add this for now at least for daily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But is it a problem to run so many stages at the same time? It looks like we are fixing an issue we don't have (yet?).
I don't have a strong preference with any of the options, but it looks simpler to just run everything at the same time if this is not a problem by now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, I'm just moving ahead and probably there would not be any issue.
I'll change it back, and if there are issues we can do this change then.