-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboards] Favorite a dashboard from within #200315
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Tagging in @elastic/appex-sharedux, since they own the favouriting feature :) I'm keeping the @elastic/kibana-presentation tag for now, since it's unclear who would really "own" this new functionality, but interested in thoughts from the SharedUX team. |
@Heenawter, This shouldn't be too difficult to implement. Here is a POC #201596 , ideally I'd reuse the component that we already have. favorite.a.dash.movThis works, but doesn't look neat. @andreadelrio, could you please take a look if we can improve this from a design perspective? |
I've been thinking of this microinteraction for this feature. I'm not sure if the loading spinner that appears will let this work though. Sandbox with code here: https://codesandbox.io/p/sandbox/exciting-neumann-4s783g |
## Summary fix #208728 This PR improves breadcrumb extension point for adding starring next to a dashboard breadcrumb #200315: - Fix breadcrumb extension didn't render in solution nav - Support multiple extensions (search sessions are deprecated and need to be enabled with kibana.yml flag, but we still need to support both UI elements) - Improve DX to unmount the extension To test: - Add `data.search.sessions.enabled: true` and see that search session UI appears in solution nav. - To test multiple, add more extensions by using `chrome.setBreadcrumbsAppendExtension`, e.g. in `src/platform/plugins/shared/data/public/search/search_service.ts` . This actually gonna be used in #200315 ![Screenshot 2025-02-05 at 14 41 21](https://github.com/user-attachments/assets/f4bece3e-6b09-4afb-94b5-291a7387118c)
Describe the feature:
Add the ability to favorite a dashboard from within a dashboard.
Describe a specific use case for the feature:
The favoriting of the dashboard is a great feature, but it relies on the user leaving their dashboard and going into the Dashboard Pages View, which is hard (if you have many dashboards) to find the one where you were just at to favorite it.
The text was updated successfully, but these errors were encountered: