Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboards] Favorite a dashboard from within #200315

Open
Erikg346 opened this issue Nov 15, 2024 · 5 comments
Open

[Dashboards] Favorite a dashboard from within #200315

Erikg346 opened this issue Nov 15, 2024 · 5 comments
Assignees
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Erikg346
Copy link

Describe the feature:
Add the ability to favorite a dashboard from within a dashboard.

Describe a specific use case for the feature:
The favoriting of the dashboard is a great feature, but it relies on the user leaving their dashboard and going into the Dashboard Pages View, which is hard (if you have many dashboards) to find the one where you were just at to favorite it.

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 15, 2024
@ghudgins ghudgins added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 17, 2024
@Heenawter Heenawter added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Heenawter
Copy link
Contributor

Heenawter commented Nov 19, 2024

Tagging in @elastic/appex-sharedux, since they own the favouriting feature :) I'm keeping the @elastic/kibana-presentation tag for now, since it's unclear who would really "own" this new functionality, but interested in thoughts from the SharedUX team.

@Heenawter Heenawter added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 19, 2024
@Dosant Dosant self-assigned this Nov 25, 2024
@Dosant
Copy link
Contributor

Dosant commented Nov 25, 2024

@Heenawter, This shouldn't be too difficult to implement. Here is a POC #201596 , ideally I'd reuse the component that we already have.
Here is what the POC looks like:

favorite.a.dash.mov

This works, but doesn't look neat. @andreadelrio, could you please take a look if we can improve this from a design perspective?

cc @teresaalvarezsoler

@Heenawter Heenawter added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Dec 4, 2024
@andreadelrio
Copy link
Contributor

I've been thinking of this microinteraction for this feature.

Image

I'm not sure if the loading spinner that appears will let this work though.

Sandbox with code here: https://codesandbox.io/p/sandbox/exciting-neumann-4s783g

Dosant added a commit that referenced this issue Feb 7, 2025
## Summary

fix #208728

This PR improves breadcrumb extension point for adding starring next to
a dashboard breadcrumb #200315:

- Fix breadcrumb extension didn't render in solution nav
- Support multiple extensions (search sessions are deprecated and need
to be enabled with kibana.yml flag, but we still need to support both UI
elements)
- Improve DX to unmount the extension 

To test: 

- Add `data.search.sessions.enabled: true` and see that search session
UI appears in solution nav.
- To test multiple, add more extensions by using
`chrome.setBreadcrumbsAppendExtension`, e.g. in
`src/platform/plugins/shared/data/public/search/search_service.ts` .
This actually gonna be used in
#200315

![Screenshot 2025-02-05 at 14 41
21](https://github.com/user-attachments/assets/f4bece3e-6b09-4afb-94b5-291a7387118c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

6 participants