Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC favorite a dashboard from within #201596

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

POC favorite a dashboard from within #201596

wants to merge 11 commits into from

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Nov 25, 2024 •
edited
Loading

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 25, 2024 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@Dosant Dosant mentioned this pull request Nov 25, 2024
Open
Dosant added 3 commits January 27, 2025 12:23
@Dosant
Merge branch 'main' of github.com:elastic/kibana into d/2024-11-25-fa…
6e34d15 
…vorite-dash-from-within

# Conflicts:
#	src/platform/plugins/shared/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx
@Dosant
wip
31a292e
@Dosant
add stardust effect, wip favorite dash from within
fa859ca
@Dosant Dosant requested a review from andreadelrio January 28, 2025 16:11
@Dosant Dosant mentioned this pull request Jan 29, 2025
Closed
3 tasks
@Dosant Dosant assigned Dosant and unassigned andreadelrio Jan 29, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 5, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / EsqlStarredQueriesService should display the modal when the Remove button is clicked
  • [job] [logs] Jest Tests #13 / EsqlStarredQueriesService should display the modal when the Remove button is clicked
  • [job] [logs] Jest Tests #13 / EsqlStarredQueriesService should NOT display the modal when Remove the button is clicked but the user has dismissed the modal permanently
  • [job] [logs] Jest Tests #13 / EsqlStarredQueriesService should NOT display the modal when Remove the button is clicked but the user has dismissed the modal permanently
  • [job] [logs] Jest Tests #13 / EsqlStarredQueriesService should return the button correctly
  • [job] [logs] Jest Tests #13 / EsqlStarredQueriesService should return the button correctly

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 406 407 +1
dashboard 728 729 +1
esql 211 212 +1
eventAnnotationListing 741 742 +1
filesManagement 163 164 +1
graph 285 286 +1
lens 1813 1814 +1
maps 1335 1336 +1
stackAlerts 271 272 +1
visualizations 507 508 +1
total +10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/content-management-favorites-public 45 47 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 601.8KB 603.5KB +1.7KB
esql 229.9KB 231.0KB +1.2KB
eventAnnotationListing 241.0KB 242.0KB +1.0KB
filesManagement 114.1KB 115.1KB +1.0KB
graph 421.2KB 422.2KB +1.0KB
maps 3.0MB 3.0MB +1.0KB
streamsApp 284.9KB 284.9KB +9.0B
visualizations 366.5KB 367.6KB +1.0KB
total +7.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 484.3KB 484.8KB +512.0B
observabilityShared 93.9KB 93.9KB +9.0B
total +521.0B
Unknown metric groups

API count

id before after diff
@kbn/content-management-favorites-public 46 48 +2
@kbn/core-chrome-browser 210 211 +1
total +3

History

cc @Dosant

Dosant added 2 commits February 5, 2025 14:19
@Dosant
fix tests
9c8be27
@Dosant
Merge branch 'main' of github.com:elastic/kibana into d/2024-11-25-fa…
09baf4a 
…vorite-dash-from-within

# Conflicts:
#	src/platform/packages/shared/kbn-typed-react-router-config/src/breadcrumbs/use_breadcrumbs.ts
#	x-pack/solutions/observability/plugins/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx
#	x-pack/solutions/observability/plugins/observability_shared/public/hooks/use_breadcrumbs.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadelrio andreadelrio Awaiting requested review from andreadelrio

At least 1 approving review is required to merge this pull request.

Assignees

@Dosant Dosant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dosant @elasticmachine @andreadelrio