Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Web crawler name consistency #202738

Merged
merged 8 commits into from
Dec 5, 2024
Merged

[Search] Web crawler name consistency #202738

merged 8 commits into from
Dec 5, 2024

Conversation

JoseLuisGJ
Copy link
Contributor

@JoseLuisGJ JoseLuisGJ commented Dec 3, 2024 •
edited by kibanamachine
Loading

Summary

This PR fixes the areas where we display the Web Crawler naming bearing in mind these agreements :

  • We should be capitalizing when referring to the product name: Elastic Web Crawler / Web Crawler /Elastic Open Web Crawler
  • We can use lower case when referring to the feature or concept of web crawler( crawler in short): "Use the web crawler to ..."

ESS:
CleanShot 2024-12-03 at 15 19 19@2x

ES3:
CleanShot 2024-12-03 at 15 19 56@2x

Notes: Also fixing buttons that take users to the Open Web Crawler repo to open the links in a new tab and don't lose the product focus.

@JoseLuisGJ JoseLuisGJ self-assigned this Dec 3, 2024
@JoseLuisGJ JoseLuisGJ requested a review from a team as a code owner December 3, 2024 14:24
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +9.0B
serverlessSearch 366.9KB 366.9KB +16.0B
total +25.0B

History

cc @JoseLuisGJ

navarone-feekery
navarone-feekery approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JoseLuisGJ JoseLuisGJ merged commit 4899c97 into elastic:main Dec 5, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12178899974

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
❌ 8.17 Backport failed because of merge conflicts
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202738

Questions ?

Please refer to the Backport tool documentation

SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@JoseLuisGJ @SoniaSanzV
[Search] Web crawler name consistency (elastic#202738)
729c6ba 
## Summary

This PR fixes the areas where we display the Web Crawler naming bearing
in mind these agreements :
- We should be capitalizing when referring to the product name: Elastic
Web Crawler / Web Crawler /Elastic Open Web Crawler
- We can use lower case when referring to the feature or concept of web
crawler( crawler in short): "Use the web crawler to ..."

ESS:
![CleanShot 2024-12-03 at 15 19
19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)

ES3:
![CleanShot 2024-12-03 at 15 19
56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)


Notes: Also fixing buttons that take users to the Open Web Crawler repo
to open the links in a new tab and don't lose the product focus.
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@JoseLuisGJ @SoniaSanzV
[Search] Web crawler name consistency (elastic#202738)
3a46725 
## Summary

This PR fixes the areas where we display the Web Crawler naming bearing
in mind these agreements :
- We should be capitalizing when referring to the product name: Elastic
Web Crawler / Web Crawler /Elastic Open Web Crawler
- We can use lower case when referring to the feature or concept of web
crawler( crawler in short): "Use the web crawler to ..."

ESS:
![CleanShot 2024-12-03 at 15 19
19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)

ES3:
![CleanShot 2024-12-03 at 15 19
56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)


Notes: Also fixing buttons that take users to the Open Web Crawler repo
to open the links in a new tab and don't lose the product focus.
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202738 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 9, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@JoseLuisGJ @CAWilson94
[Search] Web crawler name consistency (elastic#202738)
a9ea2d2 
## Summary

This PR fixes the areas where we display the Web Crawler naming bearing
in mind these agreements :
- We should be capitalizing when referring to the product name: Elastic
Web Crawler / Web Crawler /Elastic Open Web Crawler
- We can use lower case when referring to the feature or concept of web
crawler( crawler in short): "Use the web crawler to ..."

ESS:
![CleanShot 2024-12-03 at 15 19
19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)

ES3:
![CleanShot 2024-12-03 at 15 19
56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)


Notes: Also fixing buttons that take users to the Open Web Crawler repo
to open the links in a new tab and don't lose the product focus.
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@JoseLuisGJ @Samiul-TheSoccerFan
[Search] Web crawler name consistency (elastic#202738)
aaa453d 
## Summary

This PR fixes the areas where we display the Web Crawler naming bearing
in mind these agreements :
- We should be capitalizing when referring to the product name: Elastic
Web Crawler / Web Crawler /Elastic Open Web Crawler
- We can use lower case when referring to the feature or concept of web
crawler( crawler in short): "Use the web crawler to ..."

ESS:
![CleanShot 2024-12-03 at 15 19
19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)

ES3:
![CleanShot 2024-12-03 at 15 19
56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)


Notes: Also fixing buttons that take users to the Open Web Crawler repo
to open the links in a new tab and don't lose the product focus.
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202738 locally

@JoseLuisGJ JoseLuisGJ mentioned this pull request Dec 10, 2024
Closed
@JoseLuisGJ JoseLuisGJ mentioned this pull request Dec 11, 2024
Closed
@JoseLuisGJ
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 8.17
✅ 8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

JoseLuisGJ added a commit that referenced this pull request Dec 12, 2024
@JoseLuisGJ @kibanamachine
[8.x] [Search] Web crawler name consistency (#202738) (#203780)
0b62a5e 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] Web crawler name consistency
(#202738)](#202738)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"José Luis
González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T11:32:33Z","message":"[Search]
Web crawler name consistency (#202738)\n\n## Summary\r\n\r\nThis PR
fixes the areas where we display the Web Crawler naming bearing\r\nin
mind these agreements :\r\n- We should be capitalizing when referring to
the product name: Elastic\r\nWeb Crawler / Web Crawler /Elastic Open Web
Crawler\r\n- We can use lower case when referring to the feature or
concept of web\r\ncrawler( crawler in short): \"Use the web crawler to
...\"\r\n\r\nESS:\r\n![CleanShot 2024-12-03 at 15
19\r\n19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)\r\n\r\nES3:\r\n![CleanShot
2024-12-03 at 15
19\r\n56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)\r\n\r\n\r\nNotes:
Also fixing buttons that take users to the Open Web Crawler repo\r\nto
open the links in a new tab and don't lose the product
focus.","sha":"4899c971fb8ca8309b963ba0135e66812be2584c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport
missing","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0","v8.16.2"],"number":202738,"url":"https://github.com/elastic/kibana/pull/202738","mergeCommit":{"message":"[Search]
Web crawler name consistency (#202738)\n\n## Summary\r\n\r\nThis PR
fixes the areas where we display the Web Crawler naming bearing\r\nin
mind these agreements :\r\n- We should be capitalizing when referring to
the product name: Elastic\r\nWeb Crawler / Web Crawler /Elastic Open Web
Crawler\r\n- We can use lower case when referring to the feature or
concept of web\r\ncrawler( crawler in short): \"Use the web crawler to
...\"\r\n\r\nESS:\r\n![CleanShot 2024-12-03 at 15
19\r\n19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)\r\n\r\nES3:\r\n![CleanShot
2024-12-03 at 15
19\r\n56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)\r\n\r\n\r\nNotes:
Also fixing buttons that take users to the Open Web Crawler repo\r\nto
open the links in a new tab and don't lose the product
focus.","sha":"4899c971fb8ca8309b963ba0135e66812be2584c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202738","number":202738,"mergeCommit":{"message":"[Search]
Web crawler name consistency (#202738)\n\n## Summary\r\n\r\nThis PR
fixes the areas where we display the Web Crawler naming bearing\r\nin
mind these agreements :\r\n- We should be capitalizing when referring to
the product name: Elastic\r\nWeb Crawler / Web Crawler /Elastic Open Web
Crawler\r\n- We can use lower case when referring to the feature or
concept of web\r\ncrawler( crawler in short): \"Use the web crawler to
...\"\r\n\r\nESS:\r\n![CleanShot 2024-12-03 at 15
19\r\n19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)\r\n\r\nES3:\r\n![CleanShot
2024-12-03 at 15
19\r\n56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)\r\n\r\n\r\nNotes:
Also fixing buttons that take users to the Open Web Crawler repo\r\nto
open the links in a new tab and don't lose the product
focus.","sha":"4899c971fb8ca8309b963ba0135e66812be2584c"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
JoseLuisGJ added a commit that referenced this pull request Dec 12, 2024
@JoseLuisGJ @kibanamachine
[8.17] [Search] Web crawler name consistency (#202738) (#203783)
c31b412 
# Backport

This will backport the following commits from `main` to `8.17`:
- [[Search] Web crawler name consistency
(#202738)](#202738)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"José Luis
González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T11:32:33Z","message":"[Search]
Web crawler name consistency (#202738)\n\n## Summary\r\n\r\nThis PR
fixes the areas where we display the Web Crawler naming bearing\r\nin
mind these agreements :\r\n- We should be capitalizing when referring to
the product name: Elastic\r\nWeb Crawler / Web Crawler /Elastic Open Web
Crawler\r\n- We can use lower case when referring to the feature or
concept of web\r\ncrawler( crawler in short): \"Use the web crawler to
...\"\r\n\r\nESS:\r\n![CleanShot 2024-12-03 at 15
19\r\n19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)\r\n\r\nES3:\r\n![CleanShot
2024-12-03 at 15
19\r\n56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)\r\n\r\n\r\nNotes:
Also fixing buttons that take users to the Open Web Crawler repo\r\nto
open the links in a new tab and don't lose the product
focus.","sha":"4899c971fb8ca8309b963ba0135e66812be2584c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport
missing","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0","v8.16.2"],"number":202738,"url":"https://github.com/elastic/kibana/pull/202738","mergeCommit":{"message":"[Search]
Web crawler name consistency (#202738)\n\n## Summary\r\n\r\nThis PR
fixes the areas where we display the Web Crawler naming bearing\r\nin
mind these agreements :\r\n- We should be capitalizing when referring to
the product name: Elastic\r\nWeb Crawler / Web Crawler /Elastic Open Web
Crawler\r\n- We can use lower case when referring to the feature or
concept of web\r\ncrawler( crawler in short): \"Use the web crawler to
...\"\r\n\r\nESS:\r\n![CleanShot 2024-12-03 at 15
19\r\n19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)\r\n\r\nES3:\r\n![CleanShot
2024-12-03 at 15
19\r\n56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)\r\n\r\n\r\nNotes:
Also fixing buttons that take users to the Open Web Crawler repo\r\nto
open the links in a new tab and don't lose the product
focus.","sha":"4899c971fb8ca8309b963ba0135e66812be2584c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202738","number":202738,"mergeCommit":{"message":"[Search]
Web crawler name consistency (#202738)\n\n## Summary\r\n\r\nThis PR
fixes the areas where we display the Web Crawler naming bearing\r\nin
mind these agreements :\r\n- We should be capitalizing when referring to
the product name: Elastic\r\nWeb Crawler / Web Crawler /Elastic Open Web
Crawler\r\n- We can use lower case when referring to the feature or
concept of web\r\ncrawler( crawler in short): \"Use the web crawler to
...\"\r\n\r\nESS:\r\n![CleanShot 2024-12-03 at 15
19\r\n19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)\r\n\r\nES3:\r\n![CleanShot
2024-12-03 at 15
19\r\n56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)\r\n\r\n\r\nNotes:
Also fixing buttons that take users to the Open Web Crawler repo\r\nto
open the links in a new tab and don't lose the product
focus.","sha":"4899c971fb8ca8309b963ba0135e66812be2584c"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@JoseLuisGJ @CAWilson94
[Search] Web crawler name consistency (elastic#202738)
5d98e40 
## Summary

This PR fixes the areas where we display the Web Crawler naming bearing
in mind these agreements :
- We should be capitalizing when referring to the product name: Elastic
Web Crawler / Web Crawler /Elastic Open Web Crawler
- We can use lower case when referring to the feature or concept of web
crawler( crawler in short): "Use the web crawler to ..."

ESS:
![CleanShot 2024-12-03 at 15 19
19@2x](https://github.com/user-attachments/assets/d5cba886-09b3-4c34-b6e5-565cb67b9e08)

ES3:
![CleanShot 2024-12-03 at 15 19
56@2x](https://github.com/user-attachments/assets/2a6b6a8a-697c-4001-96d8-c826b6769836)


Notes: Also fixing buttons that take users to the Open Web Crawler repo
to open the links in a new tab and don't lose the product focus.
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@mistic
Copy link
Member

mistic commented Dec 12, 2024

This PR didn't make it on time for the latest v8.17.0 BC. Updating the labels.

@mistic mistic added v8.17.1 and removed v8.17.0 labels Dec 12, 2024
@JoseLuisGJ JoseLuisGJ mentioned this pull request Dec 13, 2024
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

JoseLuisGJ added a commit that referenced this pull request Dec 16, 2024
@JoseLuisGJ @elasticmachine
[8.16] [Search] Web crawler name consistency (#202738) Manual backport (
24a47e8 
#204202)

Manual Backport
This will backport the following commits from main to 8.16:

Automatic backport were failing and using the CLI backport tool was
addind many other unnecesary files. So then doing it manually.

#202738

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@mistic mistic added v8.16.3 and removed v8.16.2 labels Dec 17, 2024
@mistic
Copy link
Member

mistic commented Dec 17, 2024

This PR didn't make it on time to be in the latest 8.16.2 BC. Updating the labels.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

11 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarone-feekery navarone-feekery navarone-feekery approved these changes

Assignees

@JoseLuisGJ JoseLuisGJ

Labels
backport:version Backport to applied version labels release_note:fix Team:Search v8.16.3 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoseLuisGJ @elasticmachine @kibanamachine @mistic @navarone-feekery