Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image Embeddable] Use client-side authc.getCurrentUser from core.security #186917

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 25, 2024

Part of #186574

Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0. The Image Embeddable plugin uses the authc.getCurrentUser method as a means to allow the user to delete image files that are attributed to them.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan requested a review from a team as a code owner June 25, 2024 17:48
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Jun 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
imageEmbeddable 66.9KB 66.9KB -4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
imageEmbeddable 5.7KB 5.7KB -49.0B
Unknown metric groups

References to deprecated APIs

id before after diff
imageEmbeddable 2 1 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 15a495a into elastic:main Jun 26, 2024
18 checks passed
@tsullivan tsullivan deleted the security-in-core/image-embeddable-plugin-public branch June 26, 2024 17:03
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants