-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Custom threshold] Save the ECS group by fields at the AAD root level #188241
[Custom threshold] Save the ECS group by fields at the AAD root level #188241
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominiqueclarke Good catch! (I don't know how you found this case; I am glad that we are aware of it now. Thanks!) |
💚 Build Succeeded
Metrics [docs]
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…alert context (#188629) ## Summary Fix adding ECS group fields to the recovered alert document for the custom threshold rule; previously ([PR](#188241)), it was added to the context instead of the root level. |Before|After| |---|---| |![image](https://github.com/user-attachments/assets/4e733454-7a89-4f89-9d0f-9abe396f6437)|![image](https://github.com/user-attachments/assets/8c043966-8a59-451d-99e8-1267dd08569e)| The ECS group by fields should be in AAD for all alerts: |Active|Recovered|No data| |---|---|---| |![image](https://github.com/user-attachments/assets/68181106-df92-4b1d-be0c-3471c28d2207)|![image](https://github.com/user-attachments/assets/0bc3b38b-f1f6-4e05-b565-7b7a1a6896f5)|![image](https://github.com/user-attachments/assets/f6950b3f-bc47-48b1-ad8d-3a8ecabc8bd8)|
Related to #183220
Summary
This PR saves the ECS group by fields at the AAD root level.
🧪 How to test