[deps] Replace compare-versions with semver #195287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
dej611
approved these changes
Oct 8, 2024
dej611
reviewed
Oct 8, 2024
There was a problem hiding this comment.
It may be worth to consider to put it into the shared bundle
There was a problem hiding this comment.
What do you think is the bundle size gain in this case?
I believe this should be a choice of the semver library owner from now on :D
opauloh
approved these changes
Oct 8, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
## Summary We are reducing the number of dependencies by replacing the `compare-versions` library with the already used `semver` library that offer the same functionality. (cherry picked from commit 31f4f2c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[deps] Replace compare-versions with semver (#195287)](#195287) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T19:23:12Z","message":"[deps] Replace compare-versions with semver (#195287)\n\n## Summary\r\n\r\nWe are reducing the number of dependencies by replacing the\r\n`compare-versions` library with the already used `semver` library that\r\noffer the same functionality.","sha":"31f4f2c9842f3f6713e004be22087379e9ccf3e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","dependencies","v9.0.0","backport:prev-minor"],"title":"[deps] Replace compare-versions with semver","number":195287,"url":"https://github.com/elastic/kibana/pull/195287","mergeCommit":{"message":"[deps] Replace compare-versions with semver (#195287)\n\n## Summary\r\n\r\nWe are reducing the number of dependencies by replacing the\r\n`compare-versions` library with the already used `semver` library that\r\noffer the same functionality.","sha":"31f4f2c9842f3f6713e004be22087379e9ccf3e7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195287","number":195287,"mergeCommit":{"message":"[deps] Replace compare-versions with semver (#195287)\n\n## Summary\r\n\r\nWe are reducing the number of dependencies by replacing the\r\n`compare-versions` library with the already used `semver` library that\r\noffer the same functionality.","sha":"31f4f2c9842f3f6713e004be22087379e9ccf3e7"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are reducing the number of dependencies by replacing the
compare-versionslibrary with the already usedsemverlibrary that offer the same functionality.