Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [deps] Replace compare-versions with semver (#195287) #195494

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

We are reducing the number of dependencies by replacing the
`compare-versions` library with the already used `semver` library that
offer the same functionality.

(cherry picked from commit 31f4f2c)
@kibanamachine kibanamachine merged commit 0770e3a into elastic:8.x Oct 8, 2024
33 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 654 653 -1
discover 991 992 +1
esqlDataGrid 362 363 +1
lens 1460 1461 +1
logsExplorer 561 562 +1
securitySolution 5928 5927 -1
slo 846 847 +1
visTypeVega 272 280 +8
total +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 507.6KB 506.3KB -1.3KB
discover 820.1KB 819.4KB -648.0B
esqlDataGrid 154.1KB 153.4KB -653.0B
lens 1.5MB 1.5MB -647.0B
securitySolution 20.6MB 20.6MB -6.9KB
slo 855.5KB 854.8KB -644.0B
visTypeVega 1.8MB 1.9MB +7.5KB
total -3.2KB

cc @markov00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants