Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the _score field #197197

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: remove the _score field #197197

merged 3 commits into from
Oct 24, 2024

Conversation

fangshun-z
Copy link
Contributor

@fangshun-z fangshun-z commented Oct 22, 2024 •
edited by kibanamachine
Loading

Fixes #189624

Before:
Pasted Graphic 1

After：
Pasted Graphic

@fangshun-z fangshun-z requested a review from a team as a code owner October 22, 2024 09:49
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Oct 22, 2024 •
edited
Loading

💚 CLA has been signed

@fangshun-z fangshun-z force-pushed the fix/discover_doc_score branch 2 times, most recently from 332e0fb to 7673465 Compare October 22, 2024 10:03
davismcphee
davismcphee reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @fangshun-z! Code change looks good and works as intended. Only request before merging is can you add a quick test for it in source.test.tsx? We should be able to get the formatted JSON from the jsonValue prop.

@davismcphee
Copy link
Contributor

/ci

@davismcphee davismcphee added release_note:fix backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Oct 23, 2024
@fangshun-z fangshun-z force-pushed the fix/discover_doc_score branch from 0c28532 to a031e0a Compare October 23, 2024 03:06
@fangshun-z
Copy link
Contributor Author

Thanks for the contribution @fangshun-z! Code change looks good and works as intended. Only request before merging is can you add a quick test for it in source.test.tsx? We should be able to get the formatted JSON from the jsonValue prop.

added

@fangshun-z fangshun-z force-pushed the fix/discover_doc_score branch from a031e0a to cd6613f Compare October 23, 2024 03:41
@kertal
Copy link
Member

kertal commented Oct 23, 2024

/ci

@fangshun-z fangshun-z force-pushed the fix/discover_doc_score branch from 6496bb3 to cd6613f Compare October 23, 2024 06:54
@davismcphee
Copy link
Contributor

/ci

@davismcphee
Copy link
Contributor

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedDocViewer 126.0KB 126.0KB +64.0B

History

@davismcphee
Copy link
Contributor

@elasticmachine run docs-build

davismcphee
davismcphee approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test and LGTM 👍

@davismcphee davismcphee merged commit 7dd66b3 into elastic:main Oct 24, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11491921891

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
@fangshun-z
fix: remove the _score field (elastic#197197)
88fb556 
Fixes elastic#189624

Before:
![Pasted Graphic
1](https://github.com/user-attachments/assets/7669c66a-339c-40a5-8a20-8d6ca452612c)

After：
![Pasted
Graphic](https://github.com/user-attachments/assets/d4fa2ac6-9be1-4c77-8976-1df568b8aa7a)

---------

Signed-off-by: fangshun <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
(cherry picked from commit 7dd66b3)
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 25, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

fangshun-z added a commit to fangshun-z/kibana that referenced this pull request Oct 29, 2024
@fangshun-z @davismcphee
fix: remove the _score field (elastic#197197)
85965d9 
Fixes elastic#189624

Before:
![Pasted Graphic
1](https://github.com/user-attachments/assets/7669c66a-339c-40a5-8a20-8d6ca452612c)

After：
![Pasted
Graphic](https://github.com/user-attachments/assets/d4fa2ac6-9be1-4c77-8976-1df568b8aa7a)

---------

Signed-off-by: fangshun <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

davismcphee added a commit that referenced this pull request Nov 1, 2024
@fangshun-z @davismcphee
fix: remove the _score field (#197197) (#198101)
b0214f3 
Signed-off-by: fangshun <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197197 locally

@davismcphee davismcphee added the backport:skip This commit does not require backporting label Nov 2, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Value of _score is not the same in Table and JSON views
5 participants
@fangshun-z @davismcphee @kertal @elasticmachine @kibanamachine