Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: remove the _score field (#197197) #197561

Closed

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine requested a review from a team as a code owner October 24, 2024 03:16
@kibanamachine kibanamachine enabled auto-merge (squash) October 24, 2024 03:16
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
88fb556

Please, read and sign the above mentioned agreement if you want to contribute to this project

@kertal
Copy link
Member

kertal commented Oct 28, 2024

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Oct 28, 2024

Strange, according to #197197 (comment) the contributor was signed. @fangshun-z was there a change from your end that could lead to complaining the cla checker again?

@fangshun-z
Copy link
Contributor

Strange, according to #197197 (comment) the contributor was signed. @fangshun-z was there a change from your end that could lead to complaining the cla checker again?

I haven't had any changes on my end, but I just re-signed the agreement. Could you try triggering the process again?

@kertal
Copy link
Member

kertal commented Oct 28, 2024

sure, thx!

@kertal
Copy link
Member

kertal commented Oct 28, 2024

/ci

@kertal
Copy link
Member

kertal commented Oct 28, 2024

dear @elastic/kibana-operations , do you have an idea, why the CLA check doesn't work here, thx!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedDocViewer 126.0KB 126.1KB +64.0B

History

@davismcphee davismcphee added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jbudz
Copy link
Member

jbudz commented Oct 29, 2024

@fangshun-z thanks a lot for the contribution and your patience! It looks like GitHub swapped your email address with their noreply email when this commit was merged - https://github.com/elastic/kibana/commit/7dd66b3fd97809ce563f323397fc810c2ac21d1a.patch. Our automation is cherry-picking that commit and pulling in an email that hasn't signed the CLA.

Would you be able to open a pull request with these changes targeting the 8.x branch? Something like:

git fetch upstream main 8.x
git checkout -b backport/8.x/197197 upstream/8.x
git cherry-pick 7dd66b3fd97809ce563f323397fc810c2ac21d1a
git commit --amend --reset-author
git push origin backport/8.x/197197

@fangshun-z
Copy link
Contributor

@fangshun-z thanks a lot for the contribution and your patience! It looks like GitHub swapped your email address with their noreply email when this commit was merged - https://github.com/elastic/kibana/commit/7dd66b3fd97809ce563f323397fc810c2ac21d1a.patch. Our automation is cherry-picking that commit and pulling in an email that hasn't signed the CLA.

Would you be able to open a pull request with these changes targeting the 8.x branch? Something like:

git fetch upstream main 8.x
git checkout -b backport/8.x/197197 upstream/8.x
git cherry-pick 7dd66b3fd97809ce563f323397fc810c2ac21d1a
git commit --amend --reset-author
git push origin backport/8.x/197197

As you mentioned, I made modifications in this PR.
#198101

@davismcphee
Copy link
Contributor

Now that #198101 is merged, I think we're good to close this one. Thanks for opening up the other backport PR to get this in 👍

@davismcphee davismcphee closed this Nov 1, 2024
auto-merge was automatically disabled November 1, 2024 02:13

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants