Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UA fixtures after ES 9 deprecation fields had breaking change #203418

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix UA fixtures after ES 9 deprecation fields had breaking change #203418

merged 2 commits into from
Dec 18, 2024

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Dec 9, 2024 •
edited
Loading

Summary

Fixes #203044 #203469

Adapt UA test fixtures to be compatible with the upstream breaking change elastic/elasticsearch#117933

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant labels Dec 9, 2024
@rudolf rudolf marked this pull request as ready for review December 9, 2024 13:29
@rudolf rudolf requested a review from a team as a code owner December 9, 2024 13:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf rudolf added the backport:skip This commit does not require backporting label Dec 9, 2024
@rudolf rudolf enabled auto-merge (squash) December 9, 2024 13:29
alisonelizabeth
alisonelizabeth approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!

@rudolf rudolf mentioned this pull request Dec 9, 2024
Closed
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 9, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #112 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products
  • [job] [logs] FTR Configs #112 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products

Metrics [docs]

✅ unchanged

History

@rudolf rudolf mentioned this pull request Dec 9, 2024
Merged
@alisonelizabeth alisonelizabeth mentioned this pull request Dec 9, 2024
Closed
@rudolf rudolf self-assigned this Dec 10, 2024
@alisonelizabeth alisonelizabeth mentioned this pull request Dec 11, 2024
Closed
rudolf added a commit that referenced this pull request Dec 16, 2024
@rudolf
Skip UA deprecation logs test to allow ES promotion (#203491)
af566c0 
## Summary

Related #203044
Skips failing test to allow for ES promotion. Once promoted we can
re-enable and merge #203418 which
fixes this test.
@rudolf rudolf requested a review from a team as a code owner December 16, 2024 15:35
@rudolf
Copy link
Contributor Author

rudolf commented Dec 16, 2024

Promotion has succeeded so I hope CI will agree this time

@rudolf rudolf merged commit 8011cbf into main Dec 18, 2024
8 checks passed
@rudolf rudolf deleted the ua-deprecation-for-9 branch December 18, 2024 00:04
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@rudolf @JoseLuisGJ
Skip UA deprecation logs test to allow ES promotion (elastic#203491)
ef4aba1 
## Summary

Related elastic#203044
Skips failing test to allow for ES promotion. Once promoted we can
re-enable and merge elastic#203418 which
fixes this test.
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@rudolf @JoseLuisGJ
Fix UA fixtures after ES 9 deprecation fields had breaking change (el…
33f2aa0 
…astic#203418)

## Summary

Adapt UA test fixtures to be compatible with the upstream breaking
change elastic/elasticsearch#117933
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@rudolf @benakansara
Fix UA fixtures after ES 9 deprecation fields had breaking change (el…
d81d34f 
…astic#203418)

## Summary

Adapt UA test fixtures to be compatible with the upstream breaking
change elastic/elasticsearch#117933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

@rudolf rudolf

Labels
backport:skip This commit does not require backporting Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v9.0.0
Projects
None yet
Milestone
No milestone
5 participants
@rudolf @elasticmachine @alisonelizabeth @afharo @kibanamachine