[Search] fix: ensure App Search is used for classic nav link name #203490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
joemcelroy
approved these changes
Dec 9, 2024
|
@elasticmachine merge upstream |
TattdCodeMonkey
force-pushed
the
fix/app-search-classic-nav-link
branch
from
99dea16 to
2ed14f8
Compare
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…astic#203490) ## Summary Ensure "App Search" is the name for the app search nav link in classic mode over "Engines" which is the label for the navLink (deepLink) Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 65b0079)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
…astic#203490) ## Summary Ensure "App Search" is the name for the app search nav link in classic mode over "Engines" which is the label for the navLink (deepLink) Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 65b0079)
|
8.15 & 8.16 backports are not needed for this, the change this fixes was introduced in 8.17 (I should have used |
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…me (#203490) (#203642) # Backport This will backport the following commits from `main` to `8.x`: - [[Search] fix: ensure App Search is used for classic nav link name (#203490)](#203490) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T16:31:08Z","message":"[Search] fix: ensure App Search is used for classic nav link name (#203490)\n\n## Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav link in classic\r\nmode over \"Engines\" which is the label for the navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.18.0","v8.17.1"],"title":"[Search] fix: ensure App Search is used for classic nav link name","number":203490,"url":"https://github.com/elastic/kibana/pull/203490","mergeCommit":{"message":"[Search] fix: ensure App Search is used for classic nav link name (#203490)\n\n## Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav link in classic\r\nmode over \"Engines\" which is the label for the navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203490","number":203490,"mergeCommit":{"message":"[Search] fix: ensure App Search is used for classic nav link name (#203490)\n\n## Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav link in classic\r\nmode over \"Engines\" which is the label for the navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rodney Norris <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…ame (#203490) (#203641) # Backport This will backport the following commits from `main` to `8.17`: - [[Search] fix: ensure App Search is used for classic nav link name (#203490)](#203490) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T16:31:08Z","message":"[Search] fix: ensure App Search is used for classic nav link name (#203490)\n\n## Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav link in classic\r\nmode over \"Engines\" which is the label for the navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.18.0","v8.17.1"],"title":"[Search] fix: ensure App Search is used for classic nav link name","number":203490,"url":"https://github.com/elastic/kibana/pull/203490","mergeCommit":{"message":"[Search] fix: ensure App Search is used for classic nav link name (#203490)\n\n## Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav link in classic\r\nmode over \"Engines\" which is the label for the navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203490","number":203490,"mergeCommit":{"message":"[Search] fix: ensure App Search is used for classic nav link name (#203490)\n\n## Summary\r\n\r\nEnsure \"App Search\" is the name for the app search nav link in classic\r\nmode over \"Engines\" which is the label for the navLink (deepLink)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65b00793d58775b04624a3465fbff9ed5b677b03"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rodney Norris <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…astic#203490) ## Summary Ensure "App Search" is the name for the app search nav link in classic mode over "Engines" which is the label for the navLink (deepLink) Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure "App Search" is the name for the app search nav link in classic mode over "Engines" which is the label for the navLink (deepLink)