Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] remove legacy embeddable test samples #203678

Merged
merged 4 commits into from
Dec 11, 2024
Merged

[embeddable] remove legacy embeddable test samples #203678

merged 4 commits into from
Dec 11, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 10, 2024 •
edited by kibanamachine
Loading

Remove legacy embeddable test constructs. PR removes tests that use test samples and some code that could be easily removed.

@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2024

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 142 139 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
embeddable 1.6KB 1.6KB +1.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 71.0KB 68.3KB -2.7KB
Unknown metric groups

ESLint disabled in files

id before after diff
embeddable 2 1 -1

References to deprecated APIs

id before after diff
embeddable 18 13 -5

Total ESLint disabled count

id before after diff
embeddable 5 4 -1

History

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.18.0 project:embeddableRebuild labels Dec 10, 2024
@nreese nreese marked this pull request as ready for review December 10, 2024 22:46
@nreese nreese requested a review from a team as a code owner December 10, 2024 22:46
ThomThomson
ThomThomson approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Embeddable test samples + test removal LGTM!

src/plugins/embeddable/public/lib/embeddables/compatibility/legacy_embeddable_to_api.ts Show resolved Hide resolved
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 11, 2024
@nreese nreese merged commit c59dddf into elastic:main Dec 11, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12280643837

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2024
@nreese
[embeddable] remove legacy embeddable test samples (elastic#203678)
0468d47 
Remove legacy embeddable test constructs. PR removes tests that use test
samples and some code that could be easily removed.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit c59dddf)
@kibanamachine kibanamachine mentioned this pull request Dec 11, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 11, 2024
@kibanamachine @nreese
[8.x] [embeddable] remove legacy embeddable test samples (#203678) (#…
2d86da8 
…203841)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[embeddable] remove legacy embeddable test samples
(#203678)](#203678)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T16:27:03Z","message":"[embeddable]
remove legacy embeddable test samples (#203678)\n\nRemove legacy
embeddable test constructs. PR removes tests that use test\r\nsamples
and some code that could be easily
removed.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c59dddfa452498b78877009c644690197356687d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[embeddable]
remove legacy embeddable test
samples","number":203678,"url":"https://github.com/elastic/kibana/pull/203678","mergeCommit":{"message":"[embeddable]
remove legacy embeddable test samples (#203678)\n\nRemove legacy
embeddable test constructs. PR removes tests that use test\r\nsamples
and some code that could be easily
removed.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c59dddfa452498b78877009c644690197356687d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203678","number":203678,"mergeCommit":{"message":"[embeddable]
remove legacy embeddable test samples (#203678)\n\nRemove legacy
embeddable test constructs. PR removes tests that use test\r\nsamples
and some code that could be easily
removed.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c59dddfa452498b78877009c644690197356687d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@nreese @kibanamachine @CAWilson94
[embeddable] remove legacy embeddable test samples (elastic#203678)
710012a 
Remove legacy embeddable test constructs. PR removes tests that use test
samples and some code that could be easily removed.

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@nreese @kibanamachine @CAWilson94
[embeddable] remove legacy embeddable test samples (elastic#203678)
2947701 
Remove legacy embeddable test constructs. PR removes tests that use test
samples and some code that could be easily removed.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @ThomThomson