Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [embeddable] remove legacy embeddable test samples (#203678) #203841

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Remove legacy embeddable test constructs. PR removes tests that use test
samples and some code that could be easily removed.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit c59dddf)
@kibanamachine kibanamachine merged commit 2d86da8 into elastic:8.x Dec 11, 2024
13 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 141 138 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
embeddable 1.6KB 1.6KB +1.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 70.5KB 67.8KB -2.7KB
Unknown metric groups

ESLint disabled in files

id before after diff
embeddable 2 1 -1

References to deprecated APIs

id before after diff
embeddable 18 13 -5

Total ESLint disabled count

id before after diff
embeddable 5 4 -1

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants