[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) #203820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
release_note:fix
Team:Defend Workflows
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
paul-tavares
requested review from
tomsonpl
and removed request for
szwarckonrad
ashokaditya
approved these changes
Dec 11, 2024
💚 Build Succeeded
Metrics [docs]
|
paul-tavares
deleted the
task/olm-203730-fix-connector-response-validations-for-non-json
branch
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
…xternal API responses that return non-JSON (ex. stream) (elastic#203820) ## Summary - Changes the validation for API responses from SentinelOne and Crowdstrike to allow anything - The prior fix changed it to validate that the responses were `JSON`, but the some APIs can return non-JSON: example: a `stream` as is the case for file download. (cherry picked from commit 520c7c6)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…xternal API responses that return non-JSON (ex. stream) (elastic#203820) ## Summary - Changes the validation for API responses from SentinelOne and Crowdstrike to allow anything - The prior fix changed it to validate that the responses were `JSON`, but the some APIs can return non-JSON: example: a `stream` as is the case for file download.
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
2 similar comments
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Dec 16, 2024
…xternal API responses that return non-JSON (ex. stream) (elastic#203820) ## Summary - Changes the validation for API responses from SentinelOne and Crowdstrike to allow anything - The prior fix changed it to validate that the responses were `JSON`, but the some APIs can return non-JSON: example: a `stream` as is the case for file download. (cherry picked from commit 520c7c6) # Conflicts: # x-pack/plugins/stack_connectors/server/connector_types/crowdstrike/crowdstrike.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Dec 16, 2024
…xternal API responses that return non-JSON (ex. stream) (elastic#203820) ## Summary - Changes the validation for API responses from SentinelOne and Crowdstrike to allow anything - The prior fix changed it to validate that the responses were `JSON`, but the some APIs can return non-JSON: example: a `stream` as is the case for file download. (cherry picked from commit 520c7c6) # Conflicts: # x-pack/plugins/stack_connectors/server/connector_types/crowdstrike/crowdstrike.ts
kibanamachine
added a commit
that referenced
this pull request
Dec 16, 2024
…n of external API responses that return non-JSON (ex. stream) (#203820) (#203920) # Backport This will backport the following commits from `main` to `8.x`: - [[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)](#203820) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paul Tavares","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T19:48:57Z","message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Defend Workflows","backport:prev-major","v8.18.0","v8.16.2","v8.17.1"],"title":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream)","number":203820,"url":"https://github.com/elastic/kibana/pull/203820","mergeCommit":{"message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203820","number":203820,"mergeCommit":{"message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Paul Tavares <[email protected]>
paul-tavares
added a commit
that referenced
this pull request
Dec 17, 2024
…on of external API responses that return non-JSON (ex. stream) (#203820) (#204490) # Backport This will backport the following commits from `main` to `8.16`: - [[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)](#203820) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paul Tavares","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T19:48:57Z","message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","v9.0.0","Team:Defend Workflows","backport:prev-major","v8.18.0","v8.16.2","v8.17.1"],"number":203820,"url":"https://github.com/elastic/kibana/pull/203820","mergeCommit":{"message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203820","number":203820,"mergeCommit":{"message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203920","number":203920,"state":"OPEN"},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
paul-tavares
added a commit
that referenced
this pull request
Dec 17, 2024
…on of external API responses that return non-JSON (ex. stream) (#203820) (#204487) # Backport This will backport the following commits from `main` to `8.17`: - [[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)](#203820) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paul Tavares","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T19:48:57Z","message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","v9.0.0","Team:Defend Workflows","backport:prev-major","v8.18.0","v8.16.2","v8.17.1"],"number":203820,"url":"https://github.com/elastic/kibana/pull/203820","mergeCommit":{"message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203820","number":203820,"mergeCommit":{"message":"[Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820)\n\n## Summary\r\n\r\n- Changes the validation for API responses from SentinelOne and\r\nCrowdstrike to allow anything\r\n- The prior fix changed it to validate that the responses were `JSON`,\r\nbut the some APIs can return non-JSON: example: a `stream` as is the\r\ncase for file download.","sha":"520c7c6d58356770708a0567d8fac3c55d75f8cc"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203920","number":203920,"state":"OPEN"},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
removed
the
backport missing
|
This PR didn't make it on time to be in the latest 8.16.2 BC. Updating the labels. |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…xternal API responses that return non-JSON (ex. stream) (elastic#203820) ## Summary - Changes the validation for API responses from SentinelOne and Crowdstrike to allow anything - The prior fix changed it to validate that the responses were `JSON`, but the some APIs can return non-JSON: example: a `stream` as is the case for file download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JSON, but the some APIs can return non-JSON: example: astreamas is the case for file download.