Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17] [Stack Connectors][SentinelOne + Crowdstrike] Fix the validation of external API responses that return non-JSON (ex. stream) (#203820) #204487

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

paul-tavares
Copy link
Contributor

…xternal API responses that return non-JSON (ex. stream) (elastic#203820)

## Summary

- Changes the validation for API responses from SentinelOne and
Crowdstrike to allow anything
- The prior fix changed it to validate that the responses were `JSON`,
but the some APIs can return non-JSON: example: a `stream` as is the
case for file download.

(cherry picked from commit 520c7c6)

# Conflicts:
#	x-pack/plugins/stack_connectors/server/connector_types/crowdstrike/crowdstrike.ts
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@paul-tavares paul-tavares merged commit ec8c5fa into elastic:8.17 Dec 17, 2024
8 checks passed
@paul-tavares paul-tavares deleted the backport/8.17/pr-203820 branch December 17, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants