QA fixes to align with the new borealis theme #204080

mdefazio · 2024-12-12T16:32:08Z

Summary

Fixes https://github.com/elastic/search-team/issues/8647

~~Updates non-status colors on badges and panels that were using success to accentSecondary~~. Some badges remain as success, changed non-status badges to primary
New guidance requests that buttons are changed to either text or primary rather than using accentSecondary
Changes serverless welcome banner background to match stack
Updates search labs banner to use right color <-- Background uses accentSecondary and keeps success button (Slack thread)
Adds border around code blocks so it is visible in dark mode.


Notebooks button:
Getting started Connection details:
Welcome banner on Serverless: Removes primary background
Search labs banner:
Borders in dark mode for code blocks
Crawler updates
Pipelines callouts, badges, and buttons

…-fix'

andreadelrio · 2024-12-12T18:38:25Z

x-pack/plugins/search_notebooks/public/components/notebooks_button.tsx

@@ -30,7 +30,7 @@ export const SearchNotebooksButton = ({
  if (activeView) {
    return (
      <EuiButton
-        color="success"
+        color="accentSecondary"


@mdefazio it looks like EUI won't be supporting accentSecondary as a button. Do you mind sharing the screenshot so we can help you decide what the right way to go is here? cc @ryankeairns

Pasted in following comment

andreadelrio · 2024-12-12T18:38:42Z

x-pack/plugins/search_notebooks/public/components/notebooks_button.tsx

@@ -47,7 +47,7 @@ export const SearchNotebooksButton = ({
  }
  return (
    <EuiButtonEmpty
-      color="success"
+      color="accentSecondary"


Same comment as above

accentSecondary:

primary:

active state:

text:

active state:

cc/ @julianrosado @daveyholler for awareness

I guess I'd go for primary here?

daveyholler

This looks good to me. Just need to address the comments from @andreadelrio and figure out what we need to replace accentSecondary with.

mdefazio · 2024-12-13T14:23:27Z

...ugins/enterprise_search/public/applications/shared/search_labs_banner/search_labs_banner.tsx

@@ -72,7 +73,7 @@ export const SearchLabsBanner: React.FC = () => {
          <span>
            <EuiButton
              href="https://www.elastic.co/search-labs/tutorials"
-              color="success"
+              color="accentSecondary"


@andreadelrio If the button sits inside a panel, shouldn't it follow that panels color? So does this mean we can no longer have an accentSecondary panel?

As agreed in Slack, will keep this as success panel with a success button.

JasonStoltz · 2024-12-13T14:38:30Z

I added the "backport:skip" label, just FYI. Tokens like accentSecondary, etc. won't be available in 8.x

…nto eui-theme-search-fixes

mgadewoll · 2024-12-16T08:40:29Z

packages/kbn-search-api-panels/components/cloud_details.tsx

@@ -97,7 +97,7 @@ export const CloudDetailsPanel = ({
            </EuiFlexItem>
            <EuiFlexItem grow={false}>
              <span>
-                <EuiBadge color="success">
+                <EuiBadge color="accentSecondary">


As far as I've been told, latest design decision is that EuiBadge should not support accentSecondary, we're removing it in the next Borealis version (EUI PR).
The guidance is to keep success in place.

cc @ek-so

mdefazio · 2024-12-16T15:27:06Z

I've updated this with new guidance and kept badges as success in most areas. Did change the 'Recommended' badge in cloud connection details to primary.

sphilipse

LGTM, thanks Michael!

andreadelrio

Style changes LGTM, thanks!

…nto eui-theme-search-fixes

mdefazio · 2024-12-17T17:25:12Z

Closes: #204041

elasticmachine · 2024-12-17T20:52:35Z

💚 Build Succeeded

Buildkite Build
Commit: 36ae387

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	2.6MB	2.6MB	+54.0B
`indexManagement`	699.3KB	699.3KB	+8.0B
`serverlessSearch`	369.9KB	369.8KB	-151.0B
total			-89.0B

History

💔 Build #261442 failed fd2e159
💔 Build #261116 failed 36ae387
💔 Build #260925 failed 7dfac52
💚 Build #260361 succeeded 921ab1d
💚 Build #260017 succeeded 156b0a0

## Summary Fixes elastic/search-team#8647 * ~Updates non-status colors on badges and panels that were using `success` to `accentSecondary`~. Some badges remain as `success`, changed non-status badges to `primary` * New guidance requests that buttons are changed to either `text` or `primary` rather than using `accentSecondary` * Changes serverless welcome banner background to match stack * Updates search labs banner to use right color <-- Background uses `accentSecondary` and keeps `success` button [(Slack thread](https://elastic.slack.com/archives/C7QC1JV6F/p1734103814782069)) * Adds border around code blocks so it is visible in dark mode. | | | |--------|--------| | **Notebooks button:** | ![CleanShot 2024-12-13 at 09 27 37@2x](https://github.com/user-attachments/assets/1e1aeb27-12d3-4a20-829a-6e4720e8dedf) ![CleanShot 2024-12-13 at 09 28 21@2x](https://github.com/user-attachments/assets/2dfb97f0-10f4-4b7c-8b92-19c6e937b341) | | **Getting started Connection details:** | ![CleanShot 2024-12-16 at 09 53 56@2x](https://github.com/user-attachments/assets/1404901e-2079-4046-918e-754d8e49e750) | | **Welcome banner on Serverless: Removes primary background** | ![CleanShot 2024-12-13 at 09 37 56@2x](https://github.com/user-attachments/assets/99243bd6-75b0-4cd2-8f74-f1d00af3ad07) | | **Search labs banner:** | ![CleanShot 2024-12-16 at 09 14 11@2x](https://github.com/user-attachments/assets/d0c43e88-87a9-4929-994a-ac053ec0024a) ![CleanShot 2024-12-16 at 09 13 04@2x](https://github.com/user-attachments/assets/31d9b2b3-9ce9-4292-8f85-19a6dd31c9b2) | | **Borders in dark mode for code blocks** | ![CleanShot 2024-12-13 at 09 48 27@2x](https://github.com/user-attachments/assets/f3a002c4-bf3e-4d33-bce5-862477db073c) | | Crawler updates | ![CleanShot 2024-12-16 at 15 16 04@2x](https://github.com/user-attachments/assets/93c9e7e7-7009-4f2a-9b0b-0b127a5979bf) ![CleanShot 2024-12-16 at 15 16 51@2x](https://github.com/user-attachments/assets/f71f1f38-7e66-4cf5-8ec1-a67fe9dbf9f5) ![CleanShot 2024-12-16 at 15 24 15@2x](https://github.com/user-attachments/assets/62cc7a28-94cc-437c-b149-3ca79d334bb0) | | Pipelines callouts, badges, and buttons | ![CleanShot 2024-12-16 at 15 25 12@2x](https://github.com/user-attachments/assets/d02efa40-71d8-4140-9170-07e135b78d24) ![CleanShot 2024-12-16 at 15 25 46@2x](https://github.com/user-attachments/assets/f7ba21e3-acc8-4513-bca0-5cbb4c6ce06c) | --------- Co-authored-by: kibanamachine <[email protected]>

Prop name fixes for borealis update

34d8dc3

JoseLuisGJ self-requested a review December 12, 2024 17:58

mdefazio marked this pull request as ready for review December 12, 2024 18:10

mdefazio requested review from a team as code owners December 12, 2024 18:10

mdefazio and others added 2 commits December 12, 2024 13:11

Merge branch 'main' into eui-theme-search-fixes

d11c3c5

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

156b0a0

…-fix'

andreadelrio reviewed Dec 12, 2024

View reviewed changes

daveyholler approved these changes Dec 13, 2024

View reviewed changes

mdefazio commented Dec 13, 2024

View reviewed changes

JasonStoltz added EUI Visual Refresh backport:skip This commit does not require backporting labels Dec 13, 2024

mdefazio added 3 commits December 13, 2024 09:53

Merge branch 'main' into eui-theme-search-fixes

98f3b9e

Updates notebooks button and more badges

6368992

Merge branch 'eui-theme-search-fixes' of github.com:mdefazio/kibana i…

921ab1d

…nto eui-theme-search-fixes

mgadewoll requested changes Dec 16, 2024

View reviewed changes

mdefazio added 2 commits December 16, 2024 10:07

Update color variables with new guidance

b54cc60

Missed one of the badge reverts

7dfac52

mdefazio requested review from mgadewoll, andreadelrio and daveyholler December 16, 2024 15:15

mgadewoll approved these changes Dec 16, 2024

View reviewed changes

JoseLuisGJ approved these changes Dec 16, 2024

View reviewed changes

sphilipse approved these changes Dec 16, 2024

View reviewed changes

andreadelrio approved these changes Dec 16, 2024

View reviewed changes

daveyholler approved these changes Dec 16, 2024

View reviewed changes

Merge branch 'main' into eui-theme-search-fixes

3cb5c1a

ryankeairns added the release_note:skip Skip the PR/issue when compiling release notes label Dec 16, 2024

mdefazio added 3 commits December 16, 2024 15:28

Merge branch 'main' into eui-theme-search-fixes

9ce32c1

Updates web crawlers

303fcbe

Merge branch 'eui-theme-search-fixes' of github.com:mdefazio/kibana i…

36ae387

…nto eui-theme-search-fixes

mdefazio requested a review from a team as a code owner December 16, 2024 21:02

SoniaSanzV approved these changes Dec 17, 2024

View reviewed changes

mdefazio enabled auto-merge (squash) December 17, 2024 15:09

mdefazio force-pushed the eui-theme-search-fixes branch from fd2e159 to 36ae387 Compare December 17, 2024 19:26

mdefazio merged commit 42f94e2 into elastic:main Dec 17, 2024
8 checks passed

kibanamachine added the v9.0.0 label Dec 17, 2024

mdefazio mentioned this pull request Dec 17, 2024

[Search] Design Review EUI Borealis #204041

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QA fixes to align with the new borealis theme #204080

QA fixes to align with the new borealis theme #204080

mdefazio commented Dec 12, 2024 •

edited

Loading

andreadelrio Dec 12, 2024

mdefazio Dec 13, 2024

andreadelrio Dec 12, 2024

mdefazio Dec 13, 2024 •

edited

Loading

daveyholler left a comment

mdefazio Dec 13, 2024

andreadelrio Dec 13, 2024

JasonStoltz commented Dec 13, 2024

mgadewoll Dec 16, 2024

mdefazio commented Dec 16, 2024

sphilipse left a comment

andreadelrio left a comment

mdefazio commented Dec 17, 2024

elasticmachine commented Dec 17, 2024

QA fixes to align with the new borealis theme #204080

QA fixes to align with the new borealis theme #204080

Conversation

mdefazio commented Dec 12, 2024 • edited Loading

Summary

andreadelrio Dec 12, 2024

Choose a reason for hiding this comment

mdefazio Dec 13, 2024

Choose a reason for hiding this comment

andreadelrio Dec 12, 2024

Choose a reason for hiding this comment

mdefazio Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

daveyholler left a comment

Choose a reason for hiding this comment

mdefazio Dec 13, 2024

Choose a reason for hiding this comment

andreadelrio Dec 13, 2024

Choose a reason for hiding this comment

JasonStoltz commented Dec 13, 2024

mgadewoll Dec 16, 2024

Choose a reason for hiding this comment

mdefazio commented Dec 16, 2024

sphilipse left a comment

Choose a reason for hiding this comment

andreadelrio left a comment

Choose a reason for hiding this comment

mdefazio commented Dec 17, 2024

elasticmachine commented Dec 17, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

History

mdefazio commented Dec 12, 2024 •

edited

Loading

mdefazio Dec 13, 2024 •

edited

Loading