Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA fixes to align with the new borealis theme #204080

Merged
merged 12 commits into from
Dec 17, 2024
Merged

QA fixes to align with the new borealis theme #204080

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
34d8dc3
Prop name fixes for borealis update
mdefazio Dec 12, 2024
d11c3c5
Merge branch 'main' into eui-theme-search-fixes
mdefazio Dec 12, 2024
156b0a0
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Dec 12, 2024
98f3b9e
Merge branch 'main' into eui-theme-search-fixes
mdefazio Dec 13, 2024
6368992
Updates notebooks button and more badges
mdefazio Dec 13, 2024
921ab1d
Merge branch 'eui-theme-search-fixes' of github.com:mdefazio/kibana i…
mdefazio Dec 13, 2024
b54cc60
Update color variables with new guidance
mdefazio Dec 16, 2024
7dfac52
Missed one of the badge reverts
mdefazio Dec 16, 2024
3cb5c1a
Merge branch 'main' into eui-theme-search-fixes
mdefazio Dec 16, 2024
9ce32c1
Merge branch 'main' into eui-theme-search-fixes
mdefazio Dec 16, 2024
303fcbe
Updates web crawlers
mdefazio Dec 16, 2024
36ae387
Merge branch 'eui-theme-search-fixes' of github.com:mdefazio/kibana i…
mdefazio Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-search-api-panels/components/cloud_details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export const CloudDetailsPanel = ({
</EuiFlexItem>
<EuiFlexItem grow={false}>
<span>
<EuiBadge color="success">
<EuiBadge color="accentSecondary">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I've been told, latest design decision is that EuiBadge should not support accentSecondary, we're removing it in the next Borealis version (EUI PR).
The guidance is to keep success in place.

cc @ek-so

<FormattedMessage
id="searchApiPanels.cloudIdDetails.elasticsearchEndpoint.recommendedBadge"
defaultMessage="Recommended"
Expand Down
2 changes: 1 addition & 1 deletion ...rprise_search/public/applications/shared/getting_started/panels/api_key_panel_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export const ApiKeyPanelContent: React.FC<ApiKeyPanelContent> = ({ apiKeys, open
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiBadge
color={(apiKeys?.length || 0) > 0 ? 'success' : 'warning'}
color={(apiKeys?.length || 0) > 0 ? 'accentSecondary' : 'warning'}
data-test-subj="api-keys-count-badge"
>
<FormattedMessage
Expand Down
7 changes: 4 additions & 3 deletions ...ns/enterprise_search/public/applications/shared/search_labs_banner/search_labs_banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@ export const SearchLabsBanner: React.FC = () => {
<EuiPanel
hasBorder
hasShadow
color="success"
color="accentSecondary"
css={css`
background-image: url(${backgroundImagePath});
background-repeat: no-repeat;
background-size: cover;
`}
>
<SearchLabsLogo
Expand Down Expand Up @@ -72,7 +73,7 @@ export const SearchLabsBanner: React.FC = () => {
<span>
<EuiButton
href="https://www.elastic.co/search-labs/tutorials"
color="success"
color="accentSecondary"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreadelrio If the button sits inside a panel, shouldn't it follow that panels color? So does this mean we can no longer have an accentSecondary panel?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed in Slack, will keep this as success panel with a success button.

fill
target="_blank"
>
Expand All @@ -86,7 +87,7 @@ export const SearchLabsBanner: React.FC = () => {
<span>
<EuiButton
href="https://www.elastic.co/search-labs/tutorials/examples"
color="success"
color="accentSecondary"
target="_blank"
>
{i18n.translate('xpack.enterpriseSearch.shared.searchLabsBanner.notebooksLabel', {
Expand Down
2 changes: 1 addition & 1 deletion ...ns/vector_search/components/dev_tools_console_code_block/dev_tools_console_code_block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const DevToolsConsoleCodeBlock: React.FC<DevToolsConsoleCodeBlockProps> =

return (
<EuiThemeProvider colorMode="dark">
<EuiPanel hasShadow={false}>
<EuiPanel hasShadow={false} hasBorder>
<EuiFlexGroup direction="column" gutterSize="xs">
<EuiFlexGroup
direction="rowReverse"
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/search_notebooks/public/components/notebooks_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const SearchNotebooksButton = ({
if (activeView) {
return (
<EuiButton
color="success"
color="accentSecondary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdefazio it looks like EUI won't be supporting accentSecondary as a button. Do you mind sharing the screenshot so we can help you decide what the right way to go is here? cc @ryankeairns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pasted in following comment

fill
onClick={onClick}
size="s"
Expand All @@ -47,7 +47,7 @@ export const SearchNotebooksButton = ({
}
return (
<EuiButtonEmpty
color="success"
color="accentSecondary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor Author

@mdefazio mdefazio Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accentSecondary:
CleanShot 2024-12-13 at 09 13 05@2x

primary:
CleanShot 2024-12-13 at 09 13 59@2x

active state:
CleanShot 2024-12-13 at 09 17 20@2x

text:
CleanShot 2024-12-13 at 09 14 37@2x

active state:
CleanShot 2024-12-13 at 09 18 18@2x

cc/ @julianrosado @daveyholler for awareness

I guess I'd go for primary here?

onClick={onClick}
size="s"
iconType="documentation"
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/serverless_search/public/application/components/overview.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.serverlessSearchHeaderSection {
background-color: $euiColorPrimary;
// background-color: $euiColorPrimary;
}

.serverlessSearchHeaderSection > div {
Expand All @@ -13,4 +13,4 @@

.serverlessSearchCloudDetailsCopyPanel {
word-break: break-all;
}
}
5 changes: 1 addition & 4 deletions x-pack/plugins/serverless_search/public/application/components/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
EuiIcon,
EuiPageTemplate,
EuiPanel,
EuiText,
EuiBadge,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
Expand Down Expand Up @@ -96,9 +95,7 @@ export const ElasticsearchOverview = () => {
return (
<EuiPageTemplate offset={0} grow restrictWidth data-test-subj="svlSearchOverviewPage">
<EuiPageTemplate.Section alignment="top" className="serverlessSearchHeaderSection">
<EuiText color="ghost">
<WelcomeBanner user={user} assetBasePath={assetBasePath} />
</EuiText>
<WelcomeBanner user={user} assetBasePath={assetBasePath} />
</EuiPageTemplate.Section>
<EuiPageTemplate.Section
color="subdued"
Expand Down