🌊 Refactor APIs to follow Elasticsearch conventions #204671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
backport:prev-minor
simianhacker
changed the title
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
pheyos
approved these changes
Dec 18, 2024
flash1293
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Thanks, this looks mostly good. Left some general questions.
There were a couple smaller issues left from the conflicts - not sure if you still need it but I pushed some fixes here: 473067e
The fields page still has an issue I didn't tackle
x-pack/packages/kbn-streams-schema/src/models/stream_config/wired_stream_config.ts
Outdated
Show resolved
Hide resolved
x-pack/packages/kbn-streams-schema/src/models/streams/ingest_stream.ts
Outdated
Show resolved
Hide resolved
…to use the new types
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
flash1293
approved these changes
Dec 20, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Unknown metric groupsAPI count
History
|
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
2 tasks
flash1293
added a commit
that referenced
this pull request
Dec 25, 2024
…205121) # Backport This will backport the following commits from `main` to `8.x`: - [🌊 Refactor APIs to follow Elasticsearch conventions (#204671)](#204671) Co-authored-by: Chris Cowan <[email protected]>
Kerry350
added a commit
that referenced
this pull request
Dec 30, 2024
## Summary Small fix to the Schema Editor page after the changes in #204671. (Without this mapped fields won't be displayed as we use a read stream definition).
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 30, 2024
…5251) ## Summary Small fix to the Schema Editor page after the changes in elastic#204671. (Without this mapped fields won't be displayed as we use a read stream definition). (cherry picked from commit 8cc2f2b)
kibanamachine
added a commit
that referenced
this pull request
Dec 30, 2024
…205251) (#205266) # Backport This will backport the following commits from `main` to `8.x`: - [[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)](#205251) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T14:24:19Z","message":"[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n## Summary\r\n\r\nSmall fix to the Schema Editor page after the changes in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without this mapped fields won't be displayed as we use a read stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","Feature:Streams"],"title":"[Streams] Schema Editor isWiredStream > isWiredReadStream","number":205251,"url":"https://github.com/elastic/kibana/pull/205251","mergeCommit":{"message":"[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n## Summary\r\n\r\nSmall fix to the Schema Editor page after the changes in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without this mapped fields won't be displayed as we use a read stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205251","number":205251,"mergeCommit":{"message":"[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n## Summary\r\n\r\nSmall fix to the Schema Editor page after the changes in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without this mapped fields won't be displayed as we use a read stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the API by creating a new packaged called
@kbn/streams-schemawhere you can find all the Zod types along with some type guards. I've also updated all the API's and calls to use the new schemas.