Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux (#204959) #205508

Merged
merged 10 commits into from
Jan 5, 2025
Merged

[8.x] Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux (#204959) #205508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77d2b19
Sustainable Kibana Architecture: Move plugins owned by `@elastic/appe…
Dosant Jan 3, 2025
eb51616
revert codeowners change
Dosant Jan 3, 2025
ab52ede
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine Jan 3, 2025
f4934cd
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Jan 3, 2025
b71381e
fix reporting related differences
Dosant Jan 3, 2025
53a2701
Merge branch 'backport/8.x/pr-204959' of github.com:Dosant/kibana int…
Dosant Jan 3, 2025
d9a5f39
Restore 8.x-only Reporting files
tsullivan Jan 3, 2025
da48486
Merge pull request #14 from tsullivan/backport/8.x/pr-204959
Dosant Jan 5, 2025
88e3127
Merge branch '8.x' into backport/8.x/pr-204959
tsullivan Jan 5, 2025
ccaa831
Update removals from src/platform/plugins/shared/telemetry/schema/oss…
tsullivan Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,10 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^src\/platform\/plugins\/shared\/discover/,
/^src\/platform\/plugins\/shared\/field_formats/,
/^src\/platform\/plugins\/shared\/inspector/,
/^src\/plugins\/kibana_react/,
/^src\/plugins\/kibana_utils/,
/^src\/platform\/plugins\/shared\/kibana_react/,
/^src\/platform\/plugins\/shared\/kibana_utils/,
/^src\/platform\/plugins\/shared\/saved_search/,
/^src\/plugins\/ui_actions/,
/^src\/platform\/plugins\/shared\/ui_actions/,
/^src\/platform\/plugins\/shared\/unified_histogram/,
/^src\/plugins\/unified_search/,
/^x-pack\/platform\/packages\/shared\/kbn-elastic-assistant/,
Expand Down
4 changes: 2 additions & 2 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ snapshots.js
/x-pack/platform/plugins/private/canvas/canvas_plugin
/x-pack/platform/plugins/private/canvas/shareable_runtime/build
/x-pack/platform/plugins/private/canvas/storybook/build
/x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/**
/x-pack/plugins/reporting/server/export_types/printable_pdf_v2/server/lib/pdf/assets/**
/x-pack/platform/plugins/private/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/**
/x-pack/platform/plugins/private/reporting/server/export_types/printable_pdf_v2/server/lib/pdf/assets/**
/x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/assets/**

# package overrides
Expand Down
6 changes: 3 additions & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,14 +283,14 @@ module.exports = {
* Temporarily disable some react rules for specific plugins, remove in separate PRs
*/
{
files: ['src/plugins/kibana_react/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/plugins/shared/kibana_react/**/*.{js,mjs,ts,tsx}'],
rules: {
'react-hooks/rules-of-hooks': 'off',
'react-hooks/exhaustive-deps': 'off',
},
},
{
files: ['src/plugins/kibana_utils/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/plugins/shared/kibana_utils/**/*.{js,mjs,ts,tsx}'],
rules: {
'react-hooks/exhaustive-deps': 'off',
},
Expand Down Expand Up @@ -1926,7 +1926,7 @@ module.exports = {
'src/core/**',
'x-pack/platform/plugins/shared/features/**',
'x-pack/platform/plugins/shared/licensing/**',
'x-pack/plugins/global_search/**',
'x-pack/platform/plugins/shared/global_search/**',
'x-pack/platform/plugins/shared/cloud/**',
'src/platform/packages/shared/kbn-config-schema',
'src/plugins/status_page/**',
Expand Down
54 changes: 27 additions & 27 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ x-pack/test/alerting_api_integration/common/plugins/aad @elastic/response-ops
x-pack/platform/plugins/shared/actions @elastic/response-ops
x-pack/test/alerting_api_integration/common/plugins/actions_simulators @elastic/response-ops
src/platform/packages/shared/kbn-actions-types @elastic/response-ops
src/plugins/advanced_settings @elastic/appex-sharedux @elastic/kibana-management
src/platform/plugins/private/advanced_settings @elastic/appex-sharedux @elastic/kibana-management
x-pack/platform/packages/shared/kbn-ai-assistant @elastic/search-kibana
x-pack/platform/packages/shared/ai-assistant/common @elastic/search-kibana
x-pack/platform/packages/shared/ai-assistant/icon @elastic/appex-sharedux
Expand Down Expand Up @@ -58,7 +58,7 @@ packages/kbn-axe-config @elastic/kibana-qa
packages/kbn-babel-preset @elastic/kibana-operations
packages/kbn-babel-register @elastic/kibana-operations
packages/kbn-babel-transform @elastic/kibana-operations
x-pack/plugins/banners @elastic/appex-sharedux
x-pack/platform/plugins/private/banners @elastic/appex-sharedux
packages/kbn-bazel-runner @elastic/kibana-operations
packages/kbn-bfetch-error @elastic/appex-sharedux
examples/bfetch_explorer @elastic/appex-sharedux
Expand Down Expand Up @@ -110,7 +110,7 @@ examples/content_management_examples @elastic/appex-sharedux
packages/content-management/favorites/favorites_common @elastic/appex-sharedux
packages/content-management/favorites/favorites_public @elastic/appex-sharedux
packages/content-management/favorites/favorites_server @elastic/appex-sharedux
src/plugins/content_management @elastic/appex-sharedux
src/platform/plugins/shared/content_management @elastic/appex-sharedux
packages/content-management/tabbed_table_list_view @elastic/appex-sharedux
packages/content-management/table_list_view @elastic/appex-sharedux
packages/content-management/table_list_view_common @elastic/appex-sharedux
Expand Down Expand Up @@ -346,7 +346,7 @@ packages/core/user-settings/core-user-settings-server-mocks @elastic/kibana-secu
x-pack/platform/plugins/private/cross_cluster_replication @elastic/kibana-management
packages/kbn-crypto @elastic/kibana-security
src/platform/packages/shared/kbn-crypto-browser @elastic/kibana-core
x-pack/plugins/custom_branding @elastic/appex-sharedux
x-pack/platform/plugins/private/custom_branding @elastic/appex-sharedux
src/platform/packages/shared/kbn-custom-icons @elastic/obs-ux-logs-team
x-pack/solutions/observability/packages/kbn-custom-integrations @elastic/obs-ux-logs-team
src/platform/plugins/shared/custom_integrations @elastic/fleet
Expand Down Expand Up @@ -482,8 +482,8 @@ src/platform/packages/shared/kbn-field-utils @elastic/kibana-data-discovery
x-pack/platform/plugins/shared/fields_metadata @elastic/obs-ux-logs-team
x-pack/platform/plugins/private/file_upload @elastic/kibana-presentation @elastic/ml-ui
examples/files_example @elastic/appex-sharedux
src/plugins/files_management @elastic/appex-sharedux
src/plugins/files @elastic/appex-sharedux
src/platform/plugins/private/files_management @elastic/appex-sharedux
src/platform/plugins/shared/files @elastic/appex-sharedux
packages/kbn-find-used-node-modules @elastic/kibana-operations
x-pack/platform/plugins/shared/fleet @elastic/fleet
packages/kbn-flot-charts @elastic/kibana-operations
Expand All @@ -500,9 +500,9 @@ packages/kbn-generate @elastic/kibana-operations
packages/kbn-generate-console-definitions @elastic/kibana-management
packages/kbn-generate-csv @elastic/appex-sharedux
packages/kbn-get-repo-files @elastic/kibana-operations
x-pack/plugins/global_search_bar @elastic/appex-sharedux
x-pack/plugins/global_search @elastic/appex-sharedux
x-pack/plugins/global_search_providers @elastic/appex-sharedux
x-pack/platform/plugins/private/global_search_bar @elastic/appex-sharedux
x-pack/platform/plugins/shared/global_search @elastic/appex-sharedux
x-pack/platform/plugins/private/global_search_providers @elastic/appex-sharedux
x-pack/test/plugin_functional/plugins/global_search_test @elastic/kibana-core
x-pack/plugins/graph @elastic/kibana-visualizations
examples/grid_example @elastic/kibana-presentation
Expand All @@ -511,20 +511,20 @@ x-pack/platform/plugins/private/grokdebugger @elastic/kibana-management
src/platform/packages/shared/kbn-grouping @elastic/response-ops
packages/kbn-guided-onboarding @elastic/appex-sharedux
examples/guided_onboarding_example @elastic/appex-sharedux
src/plugins/guided_onboarding @elastic/appex-sharedux
src/platform/plugins/shared/guided_onboarding @elastic/appex-sharedux
packages/kbn-handlebars @elastic/kibana-security
src/platform/packages/private/kbn-hapi-mocks @elastic/kibana-core
test/plugin_functional/plugins/hardening @elastic/kibana-security
src/platform/packages/private/kbn-health-gateway-server @elastic/kibana-core
examples/hello_world @elastic/kibana-core
src/plugins/home @elastic/kibana-core
src/platform/plugins/shared/home @elastic/kibana-core
packages/home/sample_data_card @elastic/appex-sharedux
packages/home/sample_data_tab @elastic/appex-sharedux
packages/home/sample_data_types @elastic/appex-sharedux
src/platform/packages/shared/kbn-i18n @elastic/kibana-core
src/platform/packages/shared/kbn-i18n-react @elastic/kibana-core
x-pack/test/functional_embedded/plugins/iframe_embedded @elastic/kibana-core
src/plugins/image_embeddable @elastic/appex-sharedux
src/platform/plugins/private/image_embeddable @elastic/appex-sharedux
packages/kbn-import-locator @elastic/kibana-operations
packages/kbn-import-resolver @elastic/kibana-operations
x-pack/solutions/security/packages/index-adapter @elastic/security-threat-hunting
Expand Down Expand Up @@ -564,10 +564,10 @@ test/plugin_functional/plugins/kbn_tp_custom_visualizations @elastic/kibana-visu
test/interpreter_functional/plugins/kbn_tp_run_pipeline @elastic/kibana-core
x-pack/test/functional_cors/plugins/kibana_cors_test @elastic/kibana-security
packages/kbn-kibana-manifest-schema @elastic/kibana-operations
src/plugins/kibana_overview @elastic/appex-sharedux
src/plugins/kibana_react @elastic/appex-sharedux
src/platform/plugins/private/kibana_overview @elastic/appex-sharedux
src/platform/plugins/shared/kibana_react @elastic/appex-sharedux
src/platform/plugins/private/kibana_usage_collection @elastic/kibana-core
src/plugins/kibana_utils @elastic/appex-sharedux
src/platform/plugins/shared/kibana_utils @elastic/appex-sharedux
x-pack/solutions/security/plugins/kubernetes_security @elastic/kibana-cloud-security-posture
x-pack/platform/packages/shared/kbn-langchain @elastic/security-generative-ai
src/platform/packages/private/kbn-language-documentation @elastic/kibana-esql
Expand Down Expand Up @@ -654,11 +654,11 @@ packages/kbn-mock-idp-utils @elastic/kibana-security
packages/kbn-monaco @elastic/appex-sharedux
x-pack/platform/plugins/private/monitoring_collection @elastic/stack-monitoring
x-pack/platform/plugins/private/monitoring @elastic/stack-monitoring
src/plugins/navigation @elastic/appex-sharedux
src/platform/plugins/shared/navigation @elastic/appex-sharedux
src/platform/plugins/shared/newsfeed @elastic/kibana-core
test/common/plugins/newsfeed @elastic/kibana-core
src/plugins/no_data_page @elastic/appex-sharedux
x-pack/plugins/notifications @elastic/appex-sharedux
src/platform/plugins/private/no_data_page @elastic/appex-sharedux
x-pack/platform/plugins/shared/notifications @elastic/appex-sharedux
packages/kbn-object-versioning @elastic/appex-sharedux
packages/kbn-object-versioning-utils @elastic/appex-sharedux
x-pack/solutions/observability/plugins/observability_ai_assistant_app @elastic/obs-ai-assistant
Expand Down Expand Up @@ -742,7 +742,7 @@ packages/kbn-reporting/export_types/pdf_common @elastic/appex-sharedux
packages/kbn-reporting/export_types/png @elastic/appex-sharedux
packages/kbn-reporting/export_types/png_common @elastic/appex-sharedux
packages/kbn-reporting/mocks_server @elastic/appex-sharedux
x-pack/plugins/reporting @elastic/appex-sharedux
x-pack/platform/plugins/private/reporting @elastic/appex-sharedux
packages/kbn-reporting/public @elastic/appex-sharedux
packages/kbn-reporting/server @elastic/appex-sharedux
src/platform/packages/shared/kbn-resizable-layout @elastic/kibana-data-discovery
Expand Down Expand Up @@ -773,17 +773,17 @@ src/platform/plugins/shared/saved_objects_finder @elastic/kibana-data-discovery
test/plugin_functional/plugins/saved_objects_hidden_from_http_apis_type @elastic/kibana-core
test/plugin_functional/plugins/saved_objects_hidden_type @elastic/kibana-core
src/platform/plugins/shared/saved_objects_management @elastic/kibana-core
src/plugins/saved_objects @elastic/kibana-core
src/platform/plugins/shared/saved_objects @elastic/kibana-core
packages/kbn-saved-objects-settings @elastic/appex-sharedux
src/plugins/saved_objects_tagging_oss @elastic/appex-sharedux
x-pack/plugins/saved_objects_tagging @elastic/appex-sharedux
src/platform/plugins/shared/saved_objects_tagging_oss @elastic/appex-sharedux
x-pack/platform/plugins/private/saved_objects_tagging @elastic/appex-sharedux
packages/kbn-saved-search-component @elastic/obs-ux-logs-team
src/platform/plugins/shared/saved_search @elastic/kibana-data-discovery
packages/kbn-scout @elastic/appex-qa
packages/kbn-scout-info @elastic/appex-qa
packages/kbn-scout-reporting @elastic/appex-qa
examples/screenshot_mode_example @elastic/appex-sharedux
src/plugins/screenshot_mode @elastic/appex-sharedux
src/platform/plugins/shared/screenshot_mode @elastic/appex-sharedux
x-pack/examples/screenshotting_example @elastic/appex-sharedux
x-pack/platform/plugins/shared/screenshotting @elastic/kibana-reporting-services
packages/kbn-screenshotting-server @elastic/appex-sharedux
Expand Down Expand Up @@ -853,7 +853,7 @@ src/platform/packages/shared/kbn-server-http-tools @elastic/kibana-core
src/platform/packages/shared/kbn-server-route-repository @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-server-route-repository-client @elastic/obs-knowledge-team
src/platform/packages/shared/kbn-server-route-repository-utils @elastic/obs-knowledge-team
x-pack/plugins/serverless @elastic/appex-sharedux
x-pack/platform/plugins/shared/serverless @elastic/appex-sharedux
packages/serverless/settings/common @elastic/appex-sharedux @elastic/kibana-management
x-pack/solutions/observability/plugins/serverless_observability @elastic/obs-ux-management-team
packages/serverless/settings/observability_project @elastic/appex-sharedux @elastic/kibana-management @elastic/obs-ux-management-team
Expand All @@ -867,7 +867,7 @@ test/plugin_functional/plugins/session_notifications @elastic/kibana-core
x-pack/solutions/security/plugins/session_view @elastic/kibana-cloud-security-posture
packages/kbn-set-map @elastic/kibana-operations
examples/share_examples @elastic/appex-sharedux
src/plugins/share @elastic/appex-sharedux
src/platform/plugins/shared/share @elastic/appex-sharedux
src/platform/packages/shared/kbn-shared-svg @elastic/obs-ux-infra_services-team
packages/shared-ux/avatar/solution @elastic/appex-sharedux
packages/shared-ux/button/exit_full_screen @elastic/appex-sharedux
Expand Down Expand Up @@ -985,10 +985,10 @@ packages/kbn-ts-type-check-cli @elastic/kibana-operations
src/platform/packages/shared/kbn-typed-react-router-config @elastic/obs-knowledge-team @elastic/obs-ux-management-team
packages/kbn-ui-actions-browser @elastic/appex-sharedux
x-pack/examples/ui_actions_enhanced_examples @elastic/appex-sharedux
src/plugins/ui_actions_enhanced @elastic/appex-sharedux
src/platform/plugins/shared/ui_actions_enhanced @elastic/appex-sharedux
examples/ui_action_examples @elastic/appex-sharedux
examples/ui_actions_explorer @elastic/appex-sharedux
src/plugins/ui_actions @elastic/appex-sharedux
src/platform/plugins/shared/ui_actions @elastic/appex-sharedux
test/plugin_functional/plugins/ui_settings_plugin @elastic/kibana-core
src/platform/packages/private/kbn-ui-shared-deps-npm @elastic/kibana-operations
src/platform/packages/private/kbn-ui-shared-deps-src @elastic/kibana-operations
Expand Down
29 changes: 14 additions & 15 deletions .i18nrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"paths": {
"advancedSettings": "src/plugins/advanced_settings",
"advancedSettings": "src/platform/plugins/private/advanced_settings",
"aiAssistantManagementSelection": "src/platform/plugins/shared/ai_assistant_management/selection",
"alerts": "packages/kbn-alerts/src",
"alertsUIShared": "src/platform/packages/shared/kbn-alerts-ui-shared/src",
Expand Down Expand Up @@ -60,15 +60,15 @@
"eventAnnotationComponents": "packages/kbn-event-annotation-components",
"fieldUtils": "src/platform/packages/shared/kbn-field-utils",
"fieldFormats": "src/platform/plugins/shared/field_formats",
"files": "src/plugins/files",
"filesManagement": "src/plugins/files_management",
"files": "src/platform/plugins/shared/files",
"filesManagement": "src/platform/plugins/private/files_management",
"flot": "packages/kbn-flot-charts/lib",
"generateCsv": "packages/kbn-generate-csv",
"grouping": "src/platform/packages/shared/kbn-grouping/src",
"alertsGrouping": "x-pack/solutions/observability/packages/kbn-alerts-grouping",
"guidedOnboarding": "src/plugins/guided_onboarding",
"guidedOnboarding": "src/platform/plugins/shared/guided_onboarding",
"guidedOnboardingPackage": "packages/kbn-guided-onboarding",
"home": "src/plugins/home",
"home": "src/platform/plugins/shared/home",
"homePackages": "packages/home",
"indexPatternEditor": "src/platform/plugins/shared/data_view_editor",
"indexPatternFieldEditor": "src/platform/plugins/shared/data_view_field_editor",
Expand All @@ -78,15 +78,14 @@
"inspectorViews": "src/legacy/core_plugins/inspector_views",
"interactiveSetup": "src/plugins/interactive_setup",
"interpreter": "src/legacy/core_plugins/interpreter",
"imageEmbeddable": "src/plugins/image_embeddable",
"imageEmbeddable": "src/platform/plugins/private/image_embeddable",
"kbn": "src/legacy/core_plugins/kibana",
"kbn-esql-validation-autocomplete": "src/platform/packages/shared/kbn-esql-validation-autocomplete/src",
"kbnConfig": "src/platform/packages/shared/kbn-config/src",
"kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
"kibana_react": "src/legacy/core_plugins/kibana_react",
"kibana_utils": "src/plugins/kibana_utils",
"kibana-react": "src/plugins/kibana_react",
"kibanaOverview": "src/plugins/kibana_overview",
"kibana_utils": "src/platform/plugins/shared/kibana_utils",
"kibana-react": "src/platform/plugins/shared/kibana_react",
"kibanaOverview": "src/platform/plugins/private/kibana_overview",
"lensFormulaDocs": "packages/kbn-lens-formula-docs",
"lists": "x-pack/solutions/security/packages/kbn-securitysolution-list-utils/src",
"exceptionList-components": "x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/src",
Expand All @@ -97,7 +96,7 @@
"packages/kbn-management"
],
"monaco": "packages/kbn-monaco/src",
"navigation": ["src/plugins/navigation", "packages/solution-nav"],
"navigation": ["src/platform/plugins/shared/navigation", "packages/solution-nav"],
"links": "src/platform/plugins/private/links",
"newsfeed": "src/platform/plugins/shared/newsfeed",
"presentationUtil": "src/platform/plugins/shared/presentation_util",
Expand All @@ -106,13 +105,13 @@
"esqlEditor": "src/platform/packages/private/kbn-esql-editor",
"esqlUtils": "src/platform/packages/shared/kbn-esql-utils",
"reporting": "packages/kbn-reporting",
"savedObjects": "src/plugins/saved_objects",
"savedObjects": "src/platform/plugins/shared/saved_objects",
"savedObjectsFinder": "src/platform/plugins/shared/saved_objects_finder",
"savedObjectsManagement": "src/platform/plugins/shared/saved_objects_management",
"searchConnectors": "src/platform/packages/shared/kbn-search-connectors",
"searchConnectorsPlugin": "x-pack/solutions/search/plugins/search_connectors",
"server": "src/legacy/server",
"share": ["src/plugins/share", "packages/kbn-reporting-share"],
"share": ["src/platform/plugins/shared/share", "packages/kbn-reporting-share"],
"sharedUXPackages": "packages/shared-ux",
"searchApiKeysComponents": "x-pack/solutions/search/packages/kbn-search-api-keys-components",
"searchApiPanels": "src/platform/packages/shared/kbn-search-api-panels/",
Expand Down Expand Up @@ -140,8 +139,8 @@
"telemetry": ["src/platform/plugins/shared/telemetry", "src/platform/plugins/shared/telemetry_management_section"],
"timelion": ["src/plugins/vis_types/timelion"],
"tryInConsole": "src/platform/packages/shared/kbn-try-in-console/",
"uiActions": ["src/plugins/ui_actions", "packages/kbn-ui-actions-browser"],
"uiActionsEnhanced": "src/plugins/ui_actions_enhanced",
"uiActions": ["src/platform/plugins/shared/ui_actions", "packages/kbn-ui-actions-browser"],
"uiActionsEnhanced": "src/platform/plugins/shared/ui_actions_enhanced",
"uiActionsExamples": "examples/ui_action_examples",
"usageCollection": "src/platform/plugins/shared/usage_collection",
"userProfileComponents": "packages/kbn-user-profile-components",
Expand Down
Loading
Loading