[Obs AI Assistant] Fix editing prompt from contextual insights #206673
+46
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
Team:Obs AI Assistant
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
viduni94
added
release_note:fix
v9.0.0
backport:version
viduni94
force-pushed
the
editing-prompt-contextual-insights
branch
from
0505c81 to
32f2299
Compare
viduni94
commented
Jan 14, 2025
...ility/plugins/observability/public/pages/alert_details/alert_details_contextual_insights.tsx
Outdated
Show resolved
Hide resolved
viduni94
added a commit
to viduni94/kibana
that referenced
this pull request
Jan 15, 2025
viduni94
force-pushed
the
editing-prompt-contextual-insights
branch
from
889ab05 to
a44fc6a
Compare
viduni94
added a commit
to viduni94/kibana
that referenced
this pull request
Jan 15, 2025
neptunian
reviewed
Jan 15, 2025
...ared/observability_solution/observability_ai_assistant/public/components/insight/insight.tsx
Outdated
Show resolved
Hide resolved
viduni94
added a commit
to viduni94/kibana
that referenced
this pull request
Jan 15, 2025
TinaHeiligers
approved these changes
Jan 15, 2025
viduni94
added a commit
to viduni94/kibana
that referenced
this pull request
Jan 16, 2025
viduni94
added a commit
to viduni94/kibana
that referenced
this pull request
Jan 16, 2025
viduni94
force-pushed
the
editing-prompt-contextual-insights
branch
from
7303a9b to
828946d
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @viduni94 |
neptunian
approved these changes
Jan 16, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 16, 2025
…ic#206673) Closes elastic#201642 ## Summary ### Problem 1. Before a conversation is generated from contextual insights (before `Help me understand this alert` is clicked), if the user clicks on `Edit Prompt`, the prompt to edit is not loaded. An empty input box is loaded. 2. When a new prompt is typed in the empty input box and submitted, it throws an error (because the way the new prompt is assigned to the conversation errors out) 3. After clicking on "Help me understand this alert", if the user clicks on `Edit Prompt`, a large string is loaded with contextual information, as the prompt to edit. This is not user-friendly. (All of the above can be seen in the screen recording before the changes - attached below) ### Solution 1. Wait for the messages to be generated and then load the correct initial prompt to edit. 2. When re-assigning the new prompt to the messages, make sure to parse it and then assign correctly so that editing the prompt is user friendly. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 10a2215)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 16, 2025
…206673) (#206982) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Fix editing prompt from contextual insights (#206673)](#206673) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T16:52:44Z","message":"[Obs AI Assistant] Fix editing prompt from contextual insights (#206673)\n\nCloses https://github.com/elastic/kibana/issues/201642\r\n\r\n## Summary\r\n\r\n### Problem\r\n1. Before a conversation is generated from contextual insights (before\r\n`Help me understand this alert` is clicked), if the user clicks on `Edit\r\nPrompt`, the prompt to edit is not loaded. An empty input box is loaded.\r\n2. When a new prompt is typed in the empty input box and submitted, it\r\nthrows an error (because the way the new prompt is assigned to the\r\nconversation errors out)\r\n3. After clicking on \"Help me understand this alert\", if the user clicks\r\non `Edit Prompt`, a large string is loaded with contextual information,\r\nas the prompt to edit. This is not user-friendly.\r\n\r\n(All of the above can be seen in the screen recording before the changes\r\n- attached below)\r\n\r\n### Solution\r\n1. Wait for the messages to be generated and then load the correct\r\ninitial prompt to edit.\r\n2. When re-assigning the new prompt to the messages, make sure to parse\r\nit and then assign correctly so that editing the prompt is user\r\nfriendly.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"10a221553a1b0b4d66afd5b887e4115e3412d9d3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs AI Assistant","Team:obs-ux-management","backport:version","v8.18.0"],"title":"[Obs AI Assistant] Fix editing prompt from contextual insights","number":206673,"url":"https://github.com/elastic/kibana/pull/206673","mergeCommit":{"message":"[Obs AI Assistant] Fix editing prompt from contextual insights (#206673)\n\nCloses https://github.com/elastic/kibana/issues/201642\r\n\r\n## Summary\r\n\r\n### Problem\r\n1. Before a conversation is generated from contextual insights (before\r\n`Help me understand this alert` is clicked), if the user clicks on `Edit\r\nPrompt`, the prompt to edit is not loaded. An empty input box is loaded.\r\n2. When a new prompt is typed in the empty input box and submitted, it\r\nthrows an error (because the way the new prompt is assigned to the\r\nconversation errors out)\r\n3. After clicking on \"Help me understand this alert\", if the user clicks\r\non `Edit Prompt`, a large string is loaded with contextual information,\r\nas the prompt to edit. This is not user-friendly.\r\n\r\n(All of the above can be seen in the screen recording before the changes\r\n- attached below)\r\n\r\n### Solution\r\n1. Wait for the messages to be generated and then load the correct\r\ninitial prompt to edit.\r\n2. When re-assigning the new prompt to the messages, make sure to parse\r\nit and then assign correctly so that editing the prompt is user\r\nfriendly.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"10a221553a1b0b4d66afd5b887e4115e3412d9d3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206673","number":206673,"mergeCommit":{"message":"[Obs AI Assistant] Fix editing prompt from contextual insights (#206673)\n\nCloses https://github.com/elastic/kibana/issues/201642\r\n\r\n## Summary\r\n\r\n### Problem\r\n1. Before a conversation is generated from contextual insights (before\r\n`Help me understand this alert` is clicked), if the user clicks on `Edit\r\nPrompt`, the prompt to edit is not loaded. An empty input box is loaded.\r\n2. When a new prompt is typed in the empty input box and submitted, it\r\nthrows an error (because the way the new prompt is assigned to the\r\nconversation errors out)\r\n3. After clicking on \"Help me understand this alert\", if the user clicks\r\non `Edit Prompt`, a large string is loaded with contextual information,\r\nas the prompt to edit. This is not user-friendly.\r\n\r\n(All of the above can be seen in the screen recording before the changes\r\n- attached below)\r\n\r\n### Solution\r\n1. Wait for the messages to be generated and then load the correct\r\ninitial prompt to edit.\r\n2. When re-assigning the new prompt to the messages, make sure to parse\r\nit and then assign correctly so that editing the prompt is user\r\nfriendly.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"10a221553a1b0b4d66afd5b887e4115e3412d9d3"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201642
Summary
Problem
Help me understand this alertis clicked), if the user clicks onEdit Prompt, the prompt to edit is not loaded. An empty input box is loaded.Edit Prompt, a large string is loaded with contextual information, as the prompt to edit. This is not user-friendly.(All of the above can be seen in the screen recording before the changes - attached below)
Solution
Screen recordings:
Before the changes (with errors):
Screen.Recording.2025-01-14.at.2.23.54.PM.mov
After the changes:
Screen.Recording.2025-01-16.at.9.57.00.AM.mov
Checklist
release_note:*label is applied per the guidelines