Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Fix editing prompt from contextual insights #206673

Merged
merged 6 commits into from
Jan 16, 2025
Merged

[Obs AI Assistant] Fix editing prompt from contextual insights #206673

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0efa224
[Obs AI Assistant] Fix editing prompt from contextual insights (#201642)
viduni94 Jan 14, 2025
38b8748
[Obs AI Assistant] Export context_instruction const from a common pac…
viduni94 Jan 15, 2025
0337e80
[Obs AI Assistant] Update instruction split to only affect alerts (#2…
viduni94 Jan 15, 2025
43331ae
[Obs AI Assistant] Revert instructions split (#206673)
viduni94 Jan 16, 2025
828946d
[Obs AI Assistant] Update variable (#206673)
viduni94 Jan 16, 2025
e0e1ee8
[Obs AI Assistant] Revert kibana.jsonc new line (#206673)
viduni94 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 46 additions & 14 deletions ...d/observability_solution/observability_ai_assistant/public/components/insight/insight.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
EuiText,
EuiTextArea,
EuiCallOut,
EuiLoadingSpinner,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { cloneDeep, isArray, isEmpty, last, once } from 'lodash';
Expand Down Expand Up @@ -288,16 +289,47 @@ export function Insight({
[service]
);

const getPromptToEdit = () => {
const clonedMessages = cloneDeep(messages.messages);
const lastUserPrompt = getLastMessageOfType(clonedMessages, MessageRole.User)?.message.content;

if (!lastUserPrompt) {
return '';
}

try {
const { instructions = '' } = JSON.parse(lastUserPrompt);
return instructions.trim();
} catch (e) {
return '';
}
};

const onEditPrompt = (newPrompt: string) => {
const clonedMessages = cloneDeep(messages.messages);
const userMessage = getLastMessageOfType(clonedMessages, MessageRole.User);
if (!userMessage) return false;

userMessage.message.content = newPrompt;
setIsPromptUpdated(true);
setMessages({ messages: clonedMessages, status: FETCH_STATUS.SUCCESS });
setEditingPrompt(false);
return true;
try {
const parsedContent = JSON.parse(userMessage.message.content || '');

if (!parsedContent.instructions) {
return false;
}

// Assign the updated instructions
parsedContent.instructions = newPrompt;
userMessage.message.content = JSON.stringify(parsedContent);

setIsPromptUpdated(true);
setMessages({ messages: clonedMessages, status: FETCH_STATUS.SUCCESS });
setEditingPrompt(false);
return true;
} catch (e) {
// eslint-disable-next-line no-console
console.error('Failed to edit prompt:', e);
return false;
}
};

const handleCancel = () => {
Expand Down Expand Up @@ -372,15 +404,15 @@ export function Insight({
</>
);
} else if (isEditingPrompt) {
children = (
<PromptEdit
initialPrompt={
getLastMessageOfType(messages.messages, MessageRole.User)?.message.content || ''
}
onSend={onEditPrompt}
onCancel={handleCancel}
/>
);
const promptToEdit = getPromptToEdit();

if (messages.status === FETCH_STATUS.SUCCESS && promptToEdit) {
children = (
<PromptEdit initialPrompt={promptToEdit} onSend={onEditPrompt} onCancel={handleCancel} />
);
} else {
children = <EuiLoadingSpinner size="m" />;
}
} else if (!connectors.loading && !connectors.connectors?.length) {
children = (
<MissingCredentialsCallout connectorsManagementHref={getConnectorsManagementHref(http!)} />
Expand Down
Loading