Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to fail CI if any dependencies are unowned #206679

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Add check to fail CI if any dependencies are unowned #206679

merged 9 commits into from
Jan 16, 2025

Conversation

legrego
Copy link
Member

@legrego legrego commented Jan 14, 2025 •
edited
Loading

Summary

  • Updates scripts/dependency_ownership to use the @kbn/dev-cli-runner for consistency with other CI-related CLIs.
  • Adds a new failIfUnowned flag to exit with an error code if any dependencies are unowned.
  • Adds a new dependency ownership check to quick_checks and renovate CI steps.

From a CI run, the additional quick check executes successfully in 3 seconds:

info [quick-checks] Passed check: /opt/buildkite-agent/builds/bk-agent-prod-gcp-abc123/elastic/kibana-pull-request/kibana/.buildkite/scripts/steps/checks/dependencies_missing_owner.sh in 3s

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes dependencies Pull requests that update a dependency file backport:skip This commit does not require backporting labels Jan 14, 2025
@legrego legrego marked this pull request as ready for review January 14, 2025 21:54
@legrego legrego requested review from a team as code owners January 14, 2025 21:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@SiddharthMantri SiddharthMantri self-requested a review January 15, 2025 12:00
SiddharthMantri
SiddharthMantri approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@SiddharthMantri SiddharthMantri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legrego legrego requested a review from elena-shostak January 15, 2025 15:50
elena-shostak
elena-shostak approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@elena-shostak elena-shostak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it to use @kbn/dev-cli-runner 👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/dependency-ownership 2 1 -1

Total ESLint disabled count

id before after diff
@kbn/dependency-ownership 2 1 -1

History

@legrego legrego merged commit 395e494 into elastic:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elena-shostak elena-shostak elena-shostak approved these changes

@jbudz jbudz jbudz approved these changes

@SiddharthMantri SiddharthMantri SiddharthMantri approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:build-next-docs ci:link-docs dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legrego @elasticmachine @SiddharthMantri @jbudz @elena-shostak @kibanamachine