Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add Spaces column to Anomaly Detection, Data Frame Analytics and Trained Models management pages #206696

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jan 15, 2025

Summary

This PR adds a new Spaces column to Anomaly detection, Data Frame Analytics, and Trained Models tables for management of spaces.

Screen.Recording.2025-01-15.at.16.22.29.mov
Screen.Recording.2025-01-15.at.16.22.17.mov
Screen.Recording.2025-01-15.at.16.21.40.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@qn895 qn895 self-assigned this Jan 15, 2025
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@qn895 qn895 added the :ml label Jan 15, 2025
@qn895
Copy link
Member Author

qn895 commented Jan 15, 2025

/ci

@qn895 qn895 requested a review from jgowdyelastic January 15, 2025 22:58
@peteharverson peteharverson changed the title [ML] Add Spaces column to Anomaly detection and Data Frame Analytics job tables [ML] Add Spaces column to Anomaly Detection, Data Frame Analytics and Trained Models management pages Jan 16, 2025
@peteharverson
Copy link
Contributor

peteharverson commented Jan 16, 2025

Gave this an early test and overall looks good. However I did notice a regression in the existing Machine Learning page under Stack Management, where if the role does not have All permissions for Spaces then the following error is shown in the space management flyout if you click on the space icon for a job or trained model:

Screenshot 2025-01-16 at 13 15 34

On main this is being handled:

Screenshot 2025-01-16 at 13 06 35

@qn895
Copy link
Member Author

qn895 commented Jan 16, 2025

Gave this an early test and overall looks good. However I did notice a regression in the existing Machine Learning page under Stack Management, where if the role does not have All permissions for Spaces then the following error is shown in the space management flyout if you click on the space icon for a job or trained model:

Thanks for catching that! Fixed here d5dbdd9 (#206696)

@qn895
Copy link
Member Author

qn895 commented Jan 16, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 16, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #39 / machine learning - stack management jobs manage spaces add one space should edit job space assignment
  • [job] [logs] FTR Configs #39 / machine learning - stack management jobs manage spaces add one space should edit job space assignment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2169 2171 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.7MB 4.7MB -6.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 77.6KB 78.0KB +436.0B
Unknown metric groups

async chunk count

id before after diff
ml 111 112 +1

ESLint disabled line counts

id before after diff
ml 556 557 +1

Total ESLint disabled count

id before after diff
ml 559 560 +1

History

cc @qn895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants