refactor: move fiddle-core usage to main process #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
refactor-runner
branch
from
0d8cc2c
to
6ccf827
Compare
This was referenced Aug 29, 2023
Co-authored-by: Aryan Shridhar <[email protected]>
dsanders11
force-pushed
the
refactor-runner
branch
from
6ccf827
to
206cd51
Compare
erikian
reviewed
Aug 31, 2023
erikian
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1451 so in draft mode until that lands.
Refactor to move usage of
@electron/fiddle-coreto the main process, thus completing the full refactoring and setting up a PR to disable Node integration and enable context isolation.