Add error screens for connecting to the JWT service #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
force-pushed
the
jwt-error-screens
branch
from
8775e25 to
873ec24
Compare
|
@fkwp please can you review the wording with your Product hat on? is it too verbose? |
hughns
requested changes
Jan 16, 2025
There was a problem hiding this comment.
It would be great to see some tests for this.
Can we mock the fetch response and assert that the error is correctly mapped?
Quick brain down of errors to mock:
- DNS resolution failure
- Connection timeout
- 500 server response
- 404 server response
- JWT service rejects with non-okay response
- successful response doesn't throw error
Note that the 'verbose' parts are only shown once you press 'show details'. |
hughns
requested changes
Jan 17, 2025
robintown
force-pushed
the
jwt-error-screens
branch
from
5261204 to
9b532e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2951 diff robintown/element-call@error-screens...jwt-error-screens
The error screens look like this, leading with a minimally jargon-y message, then with a 'show details' button to put homeserver admins on the right track:
(Ignore the "status code 200" :D I just flipped the condition to get the screenshot.)