Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config service hardening #1641

Merged
merged 56 commits into from
Nov 18, 2024
Merged

Config service hardening #1641

merged 56 commits into from
Nov 18, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Integration branch for hardening the config service.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 84.47761% with 52 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (cc98016) to head (59ccf25).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
...mbracesdk/internal/injection/DeliveryModuleImpl.kt 40.74% 8 Missing and 8 partials ⚠️
...sdk/internal/config/store/RemoteConfigStoreImpl.kt 70.37% 4 Missing and 4 partials ⚠️
.../embracesdk/internal/injection/ConfigModuleImpl.kt 82.92% 0 Missing and 7 partials ⚠️
...racesdk/internal/buildinfo/BuildInfoServiceImpl.kt 80.00% 3 Missing ⚠️
...nternal/config/behavior/AppExitInfoBehaviorImpl.kt 71.42% 0 Missing and 2 partials ⚠️
...ternal/config/source/CombinedRemoteConfigSource.kt 90.00% 0 Missing and 2 partials ⚠️
...racesdk/internal/comms/api/EmbraceApiUrlBuilder.kt 93.75% 0 Missing and 1 partial ⚠️
...id/embracesdk/internal/config/ConfigServiceImpl.kt 96.00% 0 Missing and 1 partial ⚠️
...nal/config/behavior/AutoDataCaptureBehaviorImpl.kt 91.66% 0 Missing and 1 partial ⚠️
...al/config/behavior/DataCaptureEventBehaviorImpl.kt 50.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   83.79%   84.17%   +0.38%     
==========================================
  Files         456      456              
  Lines       10737    10625     -112     
  Branches     1606     1603       -3     
==========================================
- Hits         8997     8944      -53     
+ Misses       1010      945      -65     
- Partials      730      736       +6     
Files with missing lines Coverage Δ
...mbracesdk/internal/arch/DataCaptureOrchestrator.kt 94.44% <ø> (+1.85%) ⬆️
...acesdk/internal/arch/datasource/DataSourceState.kt 91.30% <ø> (-0.37%) ⬇️
.../embracesdk/internal/comms/api/ApiRequestMapper.kt 88.46% <100.00%> (ø)
...embracesdk/internal/comms/api/EmbraceApiService.kt 94.23% <ø> (+5.07%) ⬆️
...ndroid/embracesdk/internal/comms/api/EmbraceUrl.kt 82.35% <100.00%> (+1.10%) ⬆️
...sdk/internal/comms/delivery/PendingApiCallQueue.kt 96.87% <100.00%> (ø)
...acesdk/internal/config/behavior/AnrBehaviorImpl.kt 88.46% <100.00%> (+0.46%) ⬆️
...dk/internal/config/behavior/AppExitInfoBehavior.kt 100.00% <ø> (ø)
.../config/behavior/BackgroundActivityBehaviorImpl.kt 88.88% <100.00%> (+1.38%) ⬆️
...internal/config/behavior/BreadcrumbBehaviorImpl.kt 66.66% <100.00%> (-2.57%) ⬇️
... and 48 more

... and 11 files with indirect coverage changes

@fractalwrench fractalwrench changed the title Config service hardening [WIP] Config service hardening Nov 8, 2024
@fractalwrench fractalwrench changed the title [WIP] Config service hardening Config service hardening Nov 14, 2024
@fractalwrench fractalwrench marked this pull request as ready for review November 14, 2024 13:17
@fractalwrench fractalwrench requested a review from a team as a code owner November 14, 2024 13:17
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicitly approve integration branch, when it's ready

@fractalwrench fractalwrench merged commit a3d471a into main Nov 18, 2024
7 checks passed
@fractalwrench fractalwrench deleted the integration/config-hardening branch November 18, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants