-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config service hardening #1641
Merged
Merged
Config service hardening #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove config listeners
Avoid SharedPreferences for storing config
Extract config loading to separate class
Create interface for instrumented config
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Alter integration tests to use config service
Move remote config tests
Add assertions for checking config request made
Avoid inlining runTest function
Add OkHttp implementation of RemoteConfigSource interface
Disable SDK earlier in lifecycle
Add etag support to okhttp
Alter remote config implementation to use okhttp
Fix okhttp implementation
Implement store for remote config
Create combined source of remote config
Add integration tests for remote config disabling sdk
Store remote config response uncompressed
perf: systrace improvements
fractalwrench
changed the title
[WIP] Config service hardening
Config service hardening
Nov 14, 2024
Use correct endpoint for spans + logs
Create OkHttp on background thread during initialization
Simplify config behavior implementation
Purge config before persisting response
bidetofevil
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implicitly approve integration branch, when it's ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Integration branch for hardening the config service.