Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config service hardening #1641

Merged
merged 56 commits into from
Nov 18, 2024

Merge branch 'main' into integration/config-hardening

59ccf25
Select commit
Loading
Failed to load commit list.
Merged

Config service hardening #1641

Merge branch 'main' into integration/config-hardening
59ccf25
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 0s

84.17% (+0.38%) compared to cc98016

View this Pull Request on Codecov

84.17% (+0.38%) compared to cc98016

Details

Codecov Report

Attention: Patch coverage is 84.47761% with 52 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (cc98016) to head (59ccf25).

Files with missing lines Patch % Lines
...mbracesdk/internal/injection/DeliveryModuleImpl.kt 40.74% 8 Missing and 8 partials ⚠️
...sdk/internal/config/store/RemoteConfigStoreImpl.kt 70.37% 4 Missing and 4 partials ⚠️
.../embracesdk/internal/injection/ConfigModuleImpl.kt 82.92% 0 Missing and 7 partials ⚠️
...racesdk/internal/buildinfo/BuildInfoServiceImpl.kt 80.00% 3 Missing ⚠️
...nternal/config/behavior/AppExitInfoBehaviorImpl.kt 71.42% 0 Missing and 2 partials ⚠️
...ternal/config/source/CombinedRemoteConfigSource.kt 90.00% 0 Missing and 2 partials ⚠️
...racesdk/internal/comms/api/EmbraceApiUrlBuilder.kt 93.75% 0 Missing and 1 partial ⚠️
...id/embracesdk/internal/config/ConfigServiceImpl.kt 96.00% 0 Missing and 1 partial ⚠️
...nal/config/behavior/AutoDataCaptureBehaviorImpl.kt 91.66% 0 Missing and 1 partial ⚠️
...al/config/behavior/DataCaptureEventBehaviorImpl.kt 50.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   83.79%   84.17%   +0.38%     
==========================================
  Files         456      456              
  Lines       10737    10625     -112     
  Branches     1606     1603       -3     
==========================================
- Hits         8997     8944      -53     
+ Misses       1010      945      -65     
- Partials      730      736       +6
Files with missing lines Coverage Δ
...mbracesdk/internal/arch/DataCaptureOrchestrator.kt 94.44% <ø> (+1.85%) ⬆️
...acesdk/internal/arch/datasource/DataSourceState.kt 91.30% <ø> (-0.37%) ⬇️
.../embracesdk/internal/comms/api/ApiRequestMapper.kt 88.46% <100.00%> (ø)
...embracesdk/internal/comms/api/EmbraceApiService.kt 94.23% <ø> (+5.07%) ⬆️
...ndroid/embracesdk/internal/comms/api/EmbraceUrl.kt 82.35% <100.00%> (+1.10%) ⬆️
...sdk/internal/comms/delivery/PendingApiCallQueue.kt 96.87% <100.00%> (ø)
...acesdk/internal/config/behavior/AnrBehaviorImpl.kt 88.46% <100.00%> (+0.46%) ⬆️
...dk/internal/config/behavior/AppExitInfoBehavior.kt 100.00% <ø> (ø)
.../config/behavior/BackgroundActivityBehaviorImpl.kt 88.88% <100.00%> (+1.38%) ⬆️
...internal/config/behavior/BreadcrumbBehaviorImpl.kt 66.66% <100.00%> (-2.57%) ⬇️
... and 48 more

... and 11 files with indirect coverage changes

View more details on Codecov