Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JNI functions #1701

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Rename JNI functions #1701

merged 1 commit into from
Nov 21, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Renames JNI functions to follow the Kotlin code style guide & to rename them so that they reflect that they delegate for JNI calls, rather than referencing the NdkService.

Testing

Relied on existing instrumentation tests & manual test of NDK crash in example app.

@fractalwrench fractalwrench requested a review from a team as a code owner November 20, 2024 15:17
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.19%. Comparing base (ec66742) to head (8d3ff08).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...droid/embracesdk/internal/ndk/EmbraceNdkService.kt 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   84.17%   84.19%   +0.01%     
==========================================
  Files         458      457       -1     
  Lines       10685    10684       -1     
  Branches     1609     1609              
==========================================
+ Hits         8994     8995       +1     
+ Misses        958      957       -1     
+ Partials      733      732       -1     
Files with missing lines Coverage Δ
...esdk/internal/injection/NativeFeatureModuleImpl.kt 65.45% <100.00%> (ø)
...oid/embracesdk/internal/ndk/jni/JniDelegateImpl.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/ndk/EmbraceNdkService.kt 61.87% <55.55%> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Base automatically changed from add-ndk-interfaces to main November 20, 2024 16:40
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@priettt priettt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I hated the underscore 😂

@fractalwrench fractalwrench merged commit f86ee24 into main Nov 21, 2024
7 checks passed
@fractalwrench fractalwrench deleted the rename-jni-functions branch November 21, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants