Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JNI functions #1701

Merged
merged 1 commit into from
Nov 21, 2024

refactor: rename jni functions

8d3ff08
Select commit
Loading
Failed to load commit list.
Merged

Rename JNI functions #1701

refactor: rename jni functions
8d3ff08
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 0s

84.19% (+0.01%) compared to ec66742

View this Pull Request on Codecov

84.19% (+0.01%) compared to ec66742

Details

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.19%. Comparing base (ec66742) to head (8d3ff08).

Files with missing lines Patch % Lines
...droid/embracesdk/internal/ndk/EmbraceNdkService.kt 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   84.17%   84.19%   +0.01%     
==========================================
  Files         458      457       -1     
  Lines       10685    10684       -1     
  Branches     1609     1609              
==========================================
+ Hits         8994     8995       +1     
+ Misses        958      957       -1     
+ Partials      733      732       -1     
Files with missing lines Coverage Δ
...esdk/internal/injection/NativeFeatureModuleImpl.kt 65.45% <100.00%> (ø)
...oid/embracesdk/internal/ndk/jni/JniDelegateImpl.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/ndk/EmbraceNdkService.kt 61.87% <55.55%> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features: