Make peerDependency ranges more strict #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Apr 8, 2020
Co-Authored-By: Jordan Harband <[email protected]>
Co-Authored-By: Jordan Harband <[email protected]>
|
Can we add jest 26 and cut a release please? |
|
Yes! Please add jest v26! It's very discouraging that it is taking so long to support newer versions of jest, especially when it's such a simple fix. |
| "cpy-cli": "^2.0.0", | ||
| "enzyme": "^3.4.0", | ||
| "jest": "^22.0.0 || ^23.0.0 || ^24.0.0 || ^25.0.0", | ||
| "react": "^0.13.0 || ^0.14.0 || ^15.0.0 || ^16.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "jest-environment-jsdom": "^25.2.0" |
There was a problem hiding this comment.
The jest-environment-jsdom dependency needs to be just as wide as the jest dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the conversation here: #343. I'm not necessarily advocating for this change, but I created the PR so that we can talk about it separately from #343.