Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make peerDependency ranges more strict #344

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/enzyme-matchers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"url": "https://github.com/FormidableLabs/enzyme-matchers/issues"
},
"peerDependencies": {
"enzyme": ">=3.4.0"
"enzyme": "^3.4.0"
},
"dependencies": {
"circular-json-es6": "^2.0.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/jasmine-enzyme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"enzyme"
],
"peerDependencies": {
"enzyme": ">=3.4.0"
"enzyme": "^3.4.0"
},
"dependencies": {
"enzyme-matchers": "^7.1.2"
Expand All @@ -66,6 +66,7 @@
"verbose": true
},
"devDependencies": {
"enzyme": "^3.4.0",
"jasmine": "^2.8.0",
"jest-environment-enzyme": "^7.1.2",
"jest-enzyme": "^7.1.2",
Expand Down
11 changes: 7 additions & 4 deletions packages/jest-environment-enzyme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,15 @@
"url": "https://github.com/FormidableLabs/enzyme-matchers/issues"
},
"peerDependencies": {
"enzyme": "3.x",
"jest": ">=22.0.0",
"react": "^0.13.0 || ^0.14.0 || ^15.0.0 || >=16.x"
"enzyme": "^3.4.0",
"jest": "^22.0.0 || ^23.0.0 || ^24.0.0 || ^25.0.0",
"react": "^0.13.0 || ^0.14.0 || ^15.0.0 || ^16.0.0"
},
"devDependencies": {
"cpy-cli": "^2.0.0"
"cpy-cli": "^2.0.0",
"enzyme": "^3.4.0",
"jest": "^22.0.0 || ^23.0.0 || ^24.0.0 || ^25.0.0",
"react": "^0.13.0 || ^0.14.0 || ^15.0.0 || ^16.0.0"
},
"dependencies": {
"jest-environment-jsdom": "^25.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jest-environment-jsdom dependency needs to be just as wide as the jest dependency.

Expand Down
8 changes: 5 additions & 3 deletions packages/jest-enzyme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
"url": "https://github.com/FormidableLabs/enzyme-matchers/issues"
},
"peerDependencies": {
"enzyme": ">=3.4.0",
"jest": ">=22.0.0"
"enzyme": "^3.4.0",
"jest": "^22.0.0 || ^23.0.0 || ^24.0.0 || ^25.0.0"
},
"dependencies": {
"enzyme-matchers": "^7.1.2",
Expand All @@ -57,7 +57,9 @@
"devDependencies": {
"@types/enzyme": "^3.1.11",
"@types/react": "^16.0.10",
"cpy-cli": "^2.0.0"
"cpy-cli": "^2.0.0",
"enzyme": "^3.4.0",
"jest": "^22.0.0 || ^23.0.0 || ^24.0.0 || ^25.0.0"
},
"jest": {
"transform": {
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5516,7 +5516,7 @@ jest-worker@^25.2.0:
merge-stream "^2.0.0"
supports-color "^7.0.0"

jest@^25.2.0:
"jest@^22.0.0 || ^23.0.0 || ^24.0.0 || ^25.0.0", jest@^25.2.0:
version "25.2.0"
resolved "https://registry.yarnpkg.com/jest/-/jest-25.2.0.tgz#d7b9b9ce7007002a9b4586da9bf0e0414a10a27d"
integrity sha512-6vlNxNhkZZcFBpn6GkVHyEQZKE9zAsnYithlHAnkVLJYFdD6o4dV2S7uTFcxi6k9XEEN2ilVLuTe6PJ1qgbi4w==
Expand Down Expand Up @@ -7408,7 +7408,7 @@ react-test-renderer@^16.0.0-0:
object-assign "^4.1.1"
prop-types "^15.6.0"

react@^16.5.1:
"react@^0.13.0 || ^0.14.0 || ^15.0.0 || ^16.0.0", react@^16.5.1:
version "16.5.2"
resolved "https://registry.yarnpkg.com/react/-/react-16.5.2.tgz#19f6b444ed139baa45609eee6dc3d318b3895d42"
dependencies:
Expand Down