Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #480: Fix gh action #483

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Issue #480: Fix gh action #483

merged 3 commits into from
Nov 20, 2023

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Nov 19, 2023

Fixes #480

As discussed in #480, Github action checks for R 3.5 are currently failing. This is because some packages that scoringutils imports or suggests depend on R >= 3.6.

This PR

  • makes the dependency on R 3.6 explicit in DESCRIPTION
  • updates gh action to use R 3.6 instead of R 3.5
  • replaces |> with %>% in some tests that failed because of the new pipe operator

@nikosbosse nikosbosse changed the base branch from main to develop November 19, 2023 16:46
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@4df4576). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #483   +/-   ##
==========================================
  Coverage           ?   80.21%           
==========================================
  Files              ?       20           
  Lines              ?     1713           
  Branches           ?        0           
==========================================
  Hits               ?     1374           
  Misses             ?      339           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse marked this pull request as draft November 19, 2023 22:44
@nikosbosse nikosbosse requested a review from Bisaloo November 20, 2023 08:22
@nikosbosse nikosbosse marked this pull request as ready for review November 20, 2023 08:22
@nikosbosse nikosbosse merged commit 0268107 into develop Nov 20, 2023
10 of 11 checks passed
@nikosbosse nikosbosse deleted the fix-gh-action branch November 20, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: R version dependency - Failing Github Action for Ubuntu R 3.5
2 participants