Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #566: don't clean upon pkgdown deployment (this time on develop) #569

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jan 5, 2024

Description

Merges main into develop so as to have the changes from PR #567 there (we need them in both branches).

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jan 5, 2024

Stray commit will be taken on board once conflict resolved.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 173 lines in your changes are missing coverage. Please review.

Comparison is base (dd0de3e) 90.92% compared to head (8a35a7f) 85.14%.
Report is 410 commits behind head on develop.

❗ Current head 8a35a7f differs from pull request most recent head b992d3b. Consider uploading reports for the commit b992d3b to get more accurate results

Files Patch % Lines
R/metrics-quantile.R 72.68% 53 Missing ⚠️
R/check-input-helpers.R 69.62% 41 Missing ⚠️
R/utils.R 49.05% 27 Missing ⚠️
R/check-inputs-scoring-functions.R 76.54% 19 Missing ⚠️
R/validate.R 85.00% 9 Missing ⚠️
R/get_-functions.R 93.18% 6 Missing ⚠️
R/pairwise-comparisons.R 83.33% 5 Missing ⚠️
R/pit.R 83.33% 5 Missing ⚠️
R/summarise_scores.R 88.88% 5 Missing ⚠️
R/convenience-functions.R 84.61% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #569      +/-   ##
===========================================
- Coverage    90.92%   85.14%   -5.78%     
===========================================
  Files           23       21       -2     
  Lines         1399     1710     +311     
===========================================
+ Hits          1272     1456     +184     
- Misses         127      254     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbfnk sbfnk mentioned this pull request Jan 5, 2024
9 tasks
@sbfnk sbfnk merged commit fd5b1e5 into develop Jan 5, 2024
19 of 20 checks passed
@sbfnk sbfnk mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants