Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/thalse 3052 update pnpm #3339

Merged
merged 4 commits into from
Mar 7, 2024
+15,819 −2,198
Merged

Feature/thalse 3052 update pnpm #3339

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55ec70e
🐛 use correct workspace filename
torleifhalseth Mar 6, 2024
07e85d3
✨ update pnpm engine and lock file
torleifhalseth Mar 6, 2024
317b38f
💩 comment to trigger github action tests
oddvernes Mar 6, 2024
429b43f
package.json: adding back --force to init
oddvernes Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "eds",
"engines": {
"pnpm": ">=5.13.5"
"pnpm": ">=8.15.4"
},
"scripts": {
"lint": "eslint",
Expand All @@ -10,7 +10,7 @@
"lint:data-grid-react": "pnpm run lint ./packages/eds-data-grid-react",
"lint:lab": "pnpm run lint ./packages/eds-lab-react",
"lint:utils": "pnpm run lint ./packages/eds-utils",
"init": "pnpm multi install --force && pnpm run build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we should keep --force, from the documentation:
Force reinstall dependencies: refetch packages modified in store, recreate a lockfile and/or modules directory created by a non-compatible version of pnpm. Install all optionalDependencies even they don't satisfy the current environment(cpu, os, arch).
So this should be similar to deleting node_modules

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how cache is preserved in the environments running our GitHub actions, but it looks like we could setup the cache of the store using config from this example.

Not sure if this is related, but I was hoping --force would not be needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the example creates a shared cache "pnpm" and then I guess it would be listed in our caches.

"init": "pnpm install && pnpm run build",
"build": "pnpm run build:icons && pnpm run build:tokens && pnpm run build:utils && pnpm run build:core-react && pnpm run build:data-grid-react && pnpm run build:lab",
"build:core-react": "pnpm --filter @equinor/eds-core-react run build",
"build:data-grid-react": "pnpm --filter ./packages/eds-data-grid-react run build",
Expand Down
Loading