Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/thalse 3052 update pnpm #3339

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

torleifhalseth
Copy link
Collaborator

@torleifhalseth torleifhalseth commented Mar 6, 2024

related issue #3339

@torleifhalseth torleifhalseth removed the request for review from vnys March 6, 2024 12:51
@torleifhalseth torleifhalseth changed the title Feature/thalse #3052 update pnpm Feature/thalse 3052 update pnpm Mar 6, 2024
@@ -10,7 +10,7 @@
"lint:data-grid-react": "pnpm run lint ./packages/eds-data-grid-react",
"lint:lab": "pnpm run lint ./packages/eds-lab-react",
"lint:utils": "pnpm run lint ./packages/eds-utils",
"init": "pnpm multi install --force && pnpm run build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we should keep --force, from the documentation:
Force reinstall dependencies: refetch packages modified in store, recreate a lockfile and/or modules directory created by a non-compatible version of pnpm. Install all optionalDependencies even they don't satisfy the current environment(cpu, os, arch).
So this should be similar to deleting node_modules

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how cache is preserved in the environments running our GitHub actions, but it looks like we could setup the cache of the store using config from this example.

Not sure if this is related, but I was hoping --force would not be needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the example creates a shared cache "pnpm" and then I guess it would be listed in our caches.

@oddvernes
Copy link
Collaborator

This works on windows with latest pnpm 👍 (which also cut build time in half on my slow machine from almost 5 minutes to 2,5 minutes)
I will update github actions to use pnpm@"<9.0.0" in develop so we can test if it works in gh actions

Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oddvernes oddvernes merged commit ca0f4da into develop Mar 7, 2024
6 checks passed
@oddvernes oddvernes deleted the feature/thalse-3052-update-pnpm branch March 7, 2024 08:53
@torleifhalseth torleifhalseth linked an issue Mar 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Fix compatability with newest version of PNPM
2 participants