-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/thalse 3052 update pnpm #3339
Conversation
@@ -10,7 +10,7 @@ | |||
"lint:data-grid-react": "pnpm run lint ./packages/eds-data-grid-react", | |||
"lint:lab": "pnpm run lint ./packages/eds-lab-react", | |||
"lint:utils": "pnpm run lint ./packages/eds-utils", | |||
"init": "pnpm multi install --force && pnpm run build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe we should keep --force, from the documentation:
Force reinstall dependencies: refetch packages modified in store, recreate a lockfile and/or modules directory created by a non-compatible version of pnpm. Install all optionalDependencies even they don't satisfy the current environment(cpu, os, arch).
So this should be similar to deleting node_modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how cache is preserved in the environments running our GitHub actions, but it looks like we could setup the cache of the store using config from this example.
Not sure if this is related, but I was hoping --force would not be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the example creates a shared cache "pnpm" and then I guess it would be listed in our caches.
This works on windows with latest pnpm 👍 (which also cut build time in half on my slow machine from almost 5 minutes to 2,5 minutes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related issue #3339