Add check on exec_ready_i to cv32e40x decode stage
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- offload an instruction to the coprocessor only if EX is ready not to miss coprocessor response
|
@davidmallasen can you review it and see whether this may fix (or partially fix) your issue? |
|
I tested this and it doesn't fix my issue. However, this doesn't seem to conflict with the other patch that we debugged to fix my issue and that I've been using since. This other patch is available here: https://github.com/davidmallasen/x-heep/blob/fix-cv32e40x/hw/vendor/patches/openhwgroup_cv32e40x/0002-Patch-fix-cv32e40x-xif.patch I see the patch from this PR was included in a previous commit of X-HEEP. Could I create a PR also including my patch since they both seem to work together? |
|
this is already done here: #392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #365 by offloading instructions to a coprocessor only if the execution stage is ready to accept the new instruction. While this is a suboptimal solution, it prevents the ID-EX pipeline register from missing the XIF Issue Interface response from the coprocessor. More details are available in the associated issue.
This change is implemented as a patch to the
cv32e40xcore, while waiting for a better solution from its developers.Status