Added and integrated spi_obi_slave peripheral to x-heep #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly now
davideschiavone
requested changes
Nov 22, 2024
| spi_wait_for_ready(spi); | ||
|
|
||
| const uint32_t send_cmd_word = spi_create_command((spi_command_t){ | ||
| .len = 4, // 4 Bytes |
There was a problem hiding this comment.
I think that if you want to write N bytes you have to pass to the function N-1, look at the examples
|
|
||
| // Set up segment parameters -> send commands | ||
| const uint32_t send_cmd_byte = spi_create_command((spi_command_t){ | ||
| .len = 1, // 1 Byte (The SPI SLAVE IP can only take one CMD byte at a time) |
There was a problem hiding this comment.
I think that if you want to write N bytes you have to pass to the function N-1, look at the examples
…ntly issue with dummy cycle and the fifo where the tx fifo needs two spi master clock cycles to trigger which requires at least two dummy cycles
…c function doesn't work properly
… spi host was filled up and data didn't get sent out
|
👍 |
… finished) fixed and changed test structure to make it very convenient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The obi part is missing the byte enable (be) signal