Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVGL: Updated BSPs and examples for new ESP LVGL Port (LVGL9) #327

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented May 7, 2024

ESP-BSP Pull Request checklist

Change description

  • Update for all BSPs and examples for working with LVGL9 (Updated types and default configs).
  • Fixed minor issues

Closes #288

Tested HW

display

  • esp-box
  • esp-box-lite
  • esp-box-3
  • m5stack_core_s3
  • esp32_p4_function_ev_board
  • esp32_s2_kaluga_kit
  • esp32_s3_eye
  • esp32_s3_korvo_2
  • esp32_s3_lcd_ev_board
  • esp_wrover_kit
  • esp32_c3_lcdkit
  • esp32_s2_kaluga_kit

display_audio_photo

  • esp-box
  • esp-box-lite
  • esp-box-3
  • m5stack_core_s3
  • esp32_s3_korvo_2
  • esp32_s3_lcd_ev_board

display_camera

  • esp32_s2_kaluga_kit
  • esp32_s3_korvo_2
  • esp32_s3_eye
  • m5stack_core_s3

display_rotation

  • esp32_s3_korvo_2
  • esp32_s3_lcd_ev_board
  • esp-box
  • esp-box-lite
  • esp-box-3
  • m5stack_core_s3

display_usb_hid

  • esp32_p4_function_ev_board
  • esp32_s3_usb_otg

display_lvgl_demos

  • esp-box
  • esp-box-lite
  • esp-box-3
  • m5stack_core_s3
  • esp32_p4_function_ev_board
  • esp32_s2_kaluga_kit
  • esp32_s3_eye
  • esp32_s3_korvo_2
  • esp32_s3_lcd_ev_board

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch 2 times, most recently from 4f4bfe6 to 670a025 Compare May 7, 2024 13:46
@espzav espzav marked this pull request as ready for review May 21, 2024 05:55
@espzav espzav force-pushed the bsp/enable_lvgl9_support branch 11 times, most recently from f475520 to ff17327 Compare May 22, 2024 13:01
@espzav espzav force-pushed the bsp/enable_lvgl9_support branch 3 times, most recently from 1a075b2 to c70e873 Compare May 28, 2024 08:55
@espzav espzav requested review from tore-espressif and pborcin May 28, 2024 10:24
@espzav
Copy link
Collaborator Author

espzav commented May 28, 2024

@tore-espressif PTAL
@pborcin PTAL and please, could you try examples with combination of BSPs as many as possible (please write note, what did you test);

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch from c70e873 to 2183388 Compare May 29, 2024 06:38
@espzav
Copy link
Collaborator Author

espzav commented May 29, 2024

  • Updated SquareLine generator for generating LVGL V8/V9 boards

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @espzav ! I tested Squareline with LVGL v9 on Kaluga kit and several examples on Kaluga kit. All works OK.

Let's wait for more tests from @pborcin and you can go ahead with merging :)

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch from 2183388 to 7f2bfd4 Compare May 30, 2024 12:59
Copy link
Collaborator

@pborcin pborcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on esp32-s3-korvo-2 and m5stack-core-s3 and informed Vilem about some examples issues. Otherwise LGTM.

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch from 4587035 to ba697a4 Compare June 3, 2024 12:26
@espzav
Copy link
Collaborator Author

espzav commented Jun 3, 2024

Tested on esp32-s3-korvo-2 and m5stack-core-s3 and informed Vilem about some examples issues. Otherwise LGTM.

@pborcin Thank you for testing. I have fixed camera example (color was swapped on some devices and rotation on M5Stack).
There is still issue in audio_photo_example on M5Stack - crashing when open JPEG image - I am working on it.

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch from ba697a4 to 974d7a2 Compare June 4, 2024 07:52
@espzav
Copy link
Collaborator Author

espzav commented Jun 4, 2024

Tested on esp32-s3-korvo-2 and m5stack-core-s3 and informed Vilem about some examples issues. Otherwise LGTM.

@pborcin Thank you for testing. I have fixed camera example (color was swapped on some devices and rotation on M5Stack). There is still issue in audio_photo_example on M5Stack - crashing when open JPEG image - I am working on it.

Fixed audio_photo_example on M5Stack

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch from 974d7a2 to 1db2495 Compare June 4, 2024 08:57
@espzav
Copy link
Collaborator Author

espzav commented Jun 4, 2024

I made some changes in display_camera example for swapping RGB565 color and rotating on the screen for M5Stack). Please, could anybody (@tore-espressif @pborcin ) try this example with these boards?

  • esp32_s2_kaluga_kit
  • esp32_s3_korvo_2
  • esp32_s3_eye

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch 2 times, most recently from ed2e26d to fddfd4c Compare June 4, 2024 09:29
@pborcin
Copy link
Collaborator

pborcin commented Jun 4, 2024

@espzav Tested display_camera, on esp32_s3_korvo_2 it works fine. On esp32_s3_eye the main screen works as well, but colors are mashed on the status panel (cpu, fps text is still discernible).

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch 7 times, most recently from 95209f8 to 990c6b9 Compare June 10, 2024 09:21
@tore-espressif
Copy link
Collaborator

  • display_camera OK on kaluga and s3-eye
  • display OK on s3-eye
  • display_lvgl_demos OK on s3-eye

@espzav espzav force-pushed the bsp/enable_lvgl9_support branch from 990c6b9 to 6f18c70 Compare June 10, 2024 10:14
@espzav espzav force-pushed the bsp/enable_lvgl9_support branch from 6f18c70 to 76e3161 Compare June 10, 2024 11:49
@espzav espzav merged commit 8d403e7 into master Jun 10, 2024
18 checks passed
@espzav espzav deleted the bsp/enable_lvgl9_support branch June 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants