icm42670: Support I2C NG driver #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espzav
force-pushed
the
feature/support_i2c_ng_icm42670
branch
8 times, most recently
from
0bfe0da to
a895f73
Compare
espzav
force-pushed
the
feature/support_i2c_ng_icm42670
branch
from
a895f73 to
27e5698
Compare
|
@tore-espressif PTAL |
| * @param dev_addr I2C device address of sensor | ||
| * | ||
| * @return | ||
| * - NULL Fail | ||
| * - Others Success | ||
| */ | ||
| #if (ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 3, 0)) |
There was a problem hiding this comment.
I think this rule might be too limiting. The new I2C Driver-NG is available from IDFv5.2 In practice, there can be other scenarios:
- IDF v5.2 + Driver-NG
- IDF v5.3 (or later) + Legacy driver
The only rule is that the driver-ng and the legacy driver cannot be linked in the same application.
So I can see 2 options:
- Maintain two versions of this component 1.x: legacy driver, 2.x: Driver-NG
- Make this configurable through Menuconfig
ATM, option 2 seems better to me because it is aligned with linear versioning of our components and option 1 is not scalable to BSP components
There was a problem hiding this comment.
We agreed that we will make 'big leap' and support only Driver-NG in new major versions
tore-espressif
added a commit
that referenced
this pull request
Oct 10, 2024
tore-espressif
added a commit
that referenced
this pull request
Oct 11, 2024
tore-espressif
added a commit
that referenced
this pull request
Oct 14, 2024
tore-espressif
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
The first PR, how to support I2C NG driver in BSP components.